From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 27 Feb 2007 17:37:19 +0000 (GMT) Received: from phoenix.bawue.net ([193.7.176.60]:54942 "EHLO mail.bawue.net") by ftp.linux-mips.org with ESMTP id S20039171AbXB0RhO (ORCPT ); Tue, 27 Feb 2007 17:37:14 +0000 Received: from lagash (intrt.mips-uk.com [194.74.144.130]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.bawue.net (Postfix) with ESMTP id DADF3B801C; Tue, 27 Feb 2007 18:36:38 +0100 (CET) Received: from ths by lagash with local (Exim 4.63) (envelope-from ) id 1HM6Hh-0001qO-TS; Tue, 27 Feb 2007 17:38:41 +0000 Date: Tue, 27 Feb 2007 17:38:41 +0000 To: Marc St-Jean Cc: Andrew Sharp , linux-mips@linux-mips.org Subject: Re: [PATCH 2/5] mips: PMC MSP71xx mips common Message-ID: <20070227173841.GD12230@networkno.de> References: <45E465C1.50408@pmc-sierra.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45E465C1.50408@pmc-sierra.com> User-Agent: Mutt/1.5.13 (2006-08-11) From: Thiemo Seufer Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 14262 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ths@networkno.de Precedence: bulk X-list: linux-mips Marc St-Jean wrote: [snip] > > > +#ifdef CONFIG_PMC_MSP > > > + jal kernel_entry > > > +#else Maybe introduce a CONFIG_BOOT_RAW (and use it in arch/mips/Makefile to objcopy the kernel to a raw binary). > > > + /* > > > * Reserved space for exception handlers. > > > * Necessary for machines which link their kernels at KSEG0. > > > */ > > > .fill 0x400 > > > +#endif /* CONFIG_PMC_MSP */ > > > > This is getting kind of ugly. There are a whole lot of config choices > > that need to use the 'j kernel_entry'. Do they all have to have their > > own? I'm not sure what the best way is to handle them all. > > I agree but don't know the best way to handle this. I could introduce a > SYS_NO_EXEPT_FILL or similar flag but this seems excessive. > > Any other ideas from arch/mips folks? Something like #if LOADADDR == 0xffffffff80000000 .fill 0x400 #endif but by defining an appropriate name in arch/mips/Makefile instead of externalizing the load-y/LOADADDR there. Thiemo