diff for duplicates of <200702280244.12844.arnd@arndb.de> diff --git a/a/1.txt b/N1/1.txt index f36aa65..6b20d15 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,19 +1,17 @@ On Tuesday 27 February 2007, Maynard Johnson wrote: -> I have applied the "cleanup" patch that Arnd sent, but had to fix up a=20 +> I have applied the "cleanup" patch that Arnd sent, but had to fix up a > few things: -> =A0 =A0- =A0Bug fix: =A0Initialize retval in spu_task_sync.c, line 95, ot= -herwise=20 +> - Bug fix: Initialize retval in spu_task_sync.c, line 95, otherwise > OProfile this function returns non-zero and OProfile fails. -> =A0 =A0- =A0Remove unused codes in include/linux/oprofile.h -> =A0 =A0- =A0Compile warnings: =A0Initialize offset and spu_cookie at line= -s 283=20 +> - Remove unused codes in include/linux/oprofile.h +> - Compile warnings: Initialize offset and spu_cookie at lines 283 > and 284 in spu_task_sync.c ->=20 -> With these changes and some userspace changes that were necessary to=20 +> +> With these changes and some userspace changes that were necessary to > correspond with Arnd's changes, our testing was successful. ->=20 +> > A fixup patch is attached. ->=20 +> The patch does not contain any of the metadata I need to apply it (subject, description, signed-off-by). @@ -24,9 +22,9 @@ The patch does not contain any of the metadata I need to apply it > int retval; > - unsigned int offset; > - unsigned long spu_cookie, app_dcookie; -> + unsigned int offset =3D 0; -> + unsigned long spu_cookie =3D 0, app_dcookie; -> retval =3D prepare_cached_spu_info(spu, objectId); +> + unsigned int offset = 0; +> + unsigned long spu_cookie = 0, app_dcookie; +> retval = prepare_cached_spu_info(spu, objectId); > if (retval) > goto out; @@ -39,12 +37,9 @@ down the code. It's harmless most of the time, but you really should not be painting over your bugs by blindly initializing variables. -> diff -paur linux-orig/include/linux/oprofile.h linux-new/include/linux/op= -rofile.h -> --- linux-orig/include/linux/oprofile.h 2007-02-27 14:41:29.000000000 -06= -00 -> +++ linux-new/include/linux/oprofile.h 2007-02-27 14:43:18.000000000 -06= -00 +> diff -paur linux-orig/include/linux/oprofile.h linux-new/include/linux/oprofile.h +> --- linux-orig/include/linux/oprofile.h 2007-02-27 14:41:29.000000000 -0600 +> +++ linux-new/include/linux/oprofile.h 2007-02-27 14:43:18.000000000 -0600 > @@ -36,9 +36,6 @@ > #define XEN_ENTER_SWITCH_CODE 10 > #define SPU_PROFILING_CODE 11 @@ -52,10 +47,10 @@ rofile.h > -#define SPU_OFFSET_CODE 13 > -#define SPU_COOKIE_CODE 14 > -#define SPU_SHLIB_COOKIE_CODE 15 -> =20 +> > struct super_block; > struct dentry; ->=20 +> Right, I forgot about this. Arnd <>< diff --git a/a/content_digest b/N1/content_digest index 9f8139d..15b5e1a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,7 +5,8 @@ "Subject\0Re: [Cbe-oss-dev] [RFC, PATCH] CELL Oprofile SPU profiling updated patch\0" "Date\0Wed, 28 Feb 2007 02:44:12 +0100\0" "To\0cbe-oss-dev@ozlabs.org\0" - "Cc\0Gerhard Stenzel <gerhard.stenzel@de.ibm.com>" + "Cc\0Maynard Johnson <maynardj@us.ibm.com>" + Gerhard Stenzel <gerhard.stenzel@de.ibm.com> linux-kernel@vger.kernel.org linuxppc-dev@ozlabs.org Mike Perks <mperks@us.ibm.com> @@ -13,21 +14,19 @@ "\00:1\0" "b\0" "On Tuesday 27 February 2007, Maynard Johnson wrote:\n" - "> I have applied the \"cleanup\" patch that Arnd sent, but had to fix up a=20\n" + "> I have applied the \"cleanup\" patch that Arnd sent, but had to fix up a \n" "> few things:\n" - "> =A0 =A0- =A0Bug fix: =A0Initialize retval in spu_task_sync.c, line 95, ot=\n" - "herwise=20\n" + "> \302\240 \302\240- \302\240Bug fix: \302\240Initialize retval in spu_task_sync.c, line 95, otherwise \n" "> OProfile this function returns non-zero and OProfile fails.\n" - "> =A0 =A0- =A0Remove unused codes in include/linux/oprofile.h\n" - "> =A0 =A0- =A0Compile warnings: =A0Initialize offset and spu_cookie at line=\n" - "s 283=20\n" + "> \302\240 \302\240- \302\240Remove unused codes in include/linux/oprofile.h\n" + "> \302\240 \302\240- \302\240Compile warnings: \302\240Initialize offset and spu_cookie at lines 283 \n" "> and 284 in spu_task_sync.c\n" - ">=20\n" - "> With these changes and some userspace changes that were necessary to=20\n" + "> \n" + "> With these changes and some userspace changes that were necessary to \n" "> correspond with Arnd's changes, our testing was successful.\n" - ">=20\n" + "> \n" "> A fixup patch is attached.\n" - ">=20\n" + "> \n" "\n" "The patch does not contain any of the metadata I need to apply it\n" "(subject, description, signed-off-by).\n" @@ -38,9 +37,9 @@ "> int retval;\n" "> - unsigned int offset;\n" "> - unsigned long spu_cookie, app_dcookie;\n" - "> + unsigned int offset =3D 0;\n" - "> + unsigned long spu_cookie =3D 0, app_dcookie;\n" - "> retval =3D prepare_cached_spu_info(spu, objectId);\n" + "> + unsigned int offset = 0;\n" + "> + unsigned long spu_cookie = 0, app_dcookie;\n" + "> retval = prepare_cached_spu_info(spu, objectId);\n" "> if (retval)\n" "> goto out;\n" "\n" @@ -53,12 +52,9 @@ "It's harmless most of the time, but you really should not be painting\n" "over your bugs by blindly initializing variables.\n" "\n" - "> diff -paur linux-orig/include/linux/oprofile.h linux-new/include/linux/op=\n" - "rofile.h\n" - "> --- linux-orig/include/linux/oprofile.h 2007-02-27 14:41:29.000000000 -06=\n" - "00\n" - "> +++ linux-new/include/linux/oprofile.h 2007-02-27 14:43:18.000000000 -06=\n" - "00\n" + "> diff -paur linux-orig/include/linux/oprofile.h linux-new/include/linux/oprofile.h\n" + "> --- linux-orig/include/linux/oprofile.h 2007-02-27 14:41:29.000000000 -0600\n" + "> +++ linux-new/include/linux/oprofile.h 2007-02-27 14:43:18.000000000 -0600\n" "> @@ -36,9 +36,6 @@\n" "> #define XEN_ENTER_SWITCH_CODE 10\n" "> #define SPU_PROFILING_CODE 11\n" @@ -66,12 +62,12 @@ "> -#define SPU_OFFSET_CODE 13\n" "> -#define SPU_COOKIE_CODE 14\n" "> -#define SPU_SHLIB_COOKIE_CODE 15\n" - "> =20\n" + "> \n" "> struct super_block;\n" "> struct dentry;\n" - ">=20\n" + "> \n" "Right, I forgot about this.\n" "\n" "\tArnd <><" -88187e5d728aeb869a3fd7372ce25421d06d3dfd5f895b85d631c7b6b85749de +197cce74203b76194e45ac44205b5b08e4dea3128344e4ea2e7d28e1f4350fa5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.