From: Jamie Wellnitz <Jamie.Wellnitz@emulex.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: dead code in persistent tape rules
Date: Wed, 28 Feb 2007 16:07:05 +0000 [thread overview]
Message-ID: <20070228160705.GJ14924@ma.emulex.com> (raw)
In-Reply-To: <200702281510.50649.zzam@gentoo.org>
On Wed, Feb 28, 2007 at 03:10:50PM +0100, Matthias Schwarzott wrote:
> Hi there!
>
> I think last commit to udev (persistent device naming: tape devices and medium
> changers) contains strange rules that may be thought to look other way. This
> is how they look now (60-persistent-storage.rules):
>
> ACTION!="add", GOTO="persistent_storage_end"
> ACTION!="add", GOTO="persistent_tape_end"
Whoops, that's mine.
In an earlier attempt of mine, this block of rules was in a different
file and I kept this check.
>
> Second jump is never reached (as then first already branched to
> persistent_storage_end), perhaps that should be SUBSYSTEMS!="scsi" or
> similar.
As you mention, the 2nd ACTION check could be changed to check for
SCSI, something like:
SUBSYSTEMS!="scsi", GOTO="persistent_tape_end"
or both references to persistent_tape_end could be removed. I don't
think I have a preference.
>
> Matthias
>
> --
> Matthias Schwarzott (zzam)
Thanks,
Jamie
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys-and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CIDÞVDEV
> _______________________________________________
> Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
> Linux-hotplug-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
>
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CIDÞVDEV
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2007-02-28 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 14:10 dead code in persistent tape rules Matthias Schwarzott
2007-02-28 16:07 ` Jamie Wellnitz [this message]
2007-02-28 16:27 ` Kay Sievers
2007-02-28 16:42 ` Jamie Wellnitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070228160705.GJ14924@ma.emulex.com \
--to=jamie.wellnitz@emulex.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.