All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Bill Lear <rael@zopyra.com>
Cc: git@vger.kernel.org
Subject: Re: Error "fatal: cannot pread pack file: Success"
Date: Wed, 28 Feb 2007 11:32:56 -0500	[thread overview]
Message-ID: <20070228163256.GD5479@spearce.org> (raw)
In-Reply-To: <17893.44181.129918.669187@lisa.zopyra.com>

Bill Lear <rael@zopyra.com> wrote:
> >The code has this:
> >
> >        unsigned long from = obj[0].offset + obj[0].hdr_size;
> >        unsigned long len = obj[1].offset - from;
> >
> >by "offset", do you want obj[0].offset and obj[1].offset?
> >
> >How do I get the size of the packfile?  Is it obj->size?

I meant something like this:

diff --git a/index-pack.c b/index-pack.c
index cf81a99..001aa46 100644
--- a/index-pack.c
+++ b/index-pack.c
@@ -287,7 +287,7 @@ static void *get_data_from_pack(struct object_entry *obj)
 	do {
 		ssize_t n = pread(pack_fd, data + rdy, len - rdy, from + rdy);
 		if (n <= 0)
-			die("cannot pread pack file: %s", strerror(errno));
+			die("cannot pread pack file: %s from=%lu, packfile size=%lu", strerror(errno), from, lseek(pack_fd, SEEK_END, 0));
 		rdy += n;
 	} while (rdy < len);
 	data = xmalloc(obj->size);

-- 
Shawn.

  reply	other threads:[~2007-02-28 16:33 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-28  3:45 Error "fatal: cannot pread pack file: Success" Bill Lear
2007-02-28  3:57 ` Shawn O. Pearce
2007-02-28  4:47   ` Shawn O. Pearce
2007-02-28  5:55     ` Junio C Hamano
2007-02-28 15:47       ` Linus Torvalds
2007-02-28 15:28     ` Bill Lear
2007-02-28 15:48       ` Bill Lear
2007-02-28 15:54         ` Shawn O. Pearce
2007-02-28 16:12           ` Bill Lear
2007-02-28 16:23             ` Bill Lear
2007-02-28 16:32               ` Shawn O. Pearce [this message]
2007-02-28 16:40                 ` Bill Lear
2007-02-28 16:48                   ` Shawn O. Pearce
2007-02-28 16:42                 ` Morten Welinder
2007-02-28 16:49                   ` Shawn O. Pearce
2007-02-28 16:55                     ` Bill Lear
2007-02-28 17:06                       ` Shawn O. Pearce
2007-02-28 17:10                         ` Bill Lear
2007-02-28 17:43                           ` Shawn O. Pearce
2007-02-28 17:50                             ` Nicolas Pitre
2007-02-28 17:58                               ` Shawn O. Pearce
2007-02-28 19:18                             ` Bill Lear
2007-02-28 19:23                               ` Bill Lear
2007-02-28 19:40                                 ` Nicolas Pitre
2007-03-01 15:23                                   ` Bill Lear
2007-02-28 16:34             ` Linus Torvalds
2007-02-28 16:36               ` Bill Lear
2007-02-28 16:47                 ` Linus Torvalds
2007-02-28 16:52                   ` Bill Lear
2007-02-28 17:13                     ` Linus Torvalds
2007-02-28 18:18                       ` Nicolas Pitre
2007-02-28 18:37                         ` Linus Torvalds
     [not found]                           ` <17893.53091.452962.414271@lisa.zopyra.com>
2007-02-28 19:22                             ` Linus Torvalds
2007-02-28 17:42               ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070228163256.GD5479@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=rael@zopyra.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.