From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John Linville <linville@tuxdriver.com>,
Bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] bcm43xx: Fix errors in specs to code translation in B6PHY init
Date: Wed, 28 Feb 2007 18:14:00 +0100 [thread overview]
Message-ID: <200702281814.00713.mb@bu3sch.de> (raw)
In-Reply-To: <45e4a43f.BEt7jx5dMLQiM3wz%Larry.Finger@lwfinger.net>
On Tuesday 27 February 2007 22:35, Larry Finger wrote:
> There are three errors in the transcription of the latest revision to the
> B6PHY init specifications.
NACK
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> John,
>
> This patch should be applied to wireless-2.6 and sent upstream to 2.6.21-rcX.
>
> Larry
>
> Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_phy.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_phy.c
> +++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_phy.c
> @@ -859,6 +859,9 @@ static void bcm43xx_phy_initb6(struct bc
> bcm43xx_radio_write16(bcm, 0x005D, 0x0088);
> bcm43xx_radio_write16(bcm, 0x005E, 0x0088);
> bcm43xx_radio_write16(bcm, 0x007D, 0x0088);
> + bcm43xx_write32(bcm, BCM43xx_MMIO_STATUS_BITFIELD,
> + bcm43xx_read32(bcm, BCM43xx_MMIO_STATUS_BITFIELD)
> + | 0x00000200);
This is wrong.
Set bit 0x200 in the MicrocodeFlagsBitfield
http://bcm-specs.sipsolutions.net/MicrocodeFlagsBitfield
--
Greetings Michael.
prev parent reply other threads:[~2007-02-28 17:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-27 21:35 [PATCH] bcm43xx: Fix errors in specs to code translation in B6PHY init Larry Finger
2007-02-28 17:14 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702281814.00713.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.