From: Ivo van Doorn <ivdoorn@gmail.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 8/28] rt2x00: optimize mac/bssid writing
Date: Wed, 28 Feb 2007 19:48:00 +0100 [thread overview]
Message-ID: <200702281948.00464.IvDoorn@gmail.com> (raw)
In-Reply-To: <200702281946.14128.mb@bu3sch.de>
> > > Do you writel this array in a loop inside of register_multiwrite?
> > > If yes, it's broken. writel expects values in CPU endianess.
> > > This array will always be little endian.
> >
> > register_multiread uses memcpy_fromio(), and
> > register_multiwrite uses memcpy_toio().
>
> Ah, ok.
>
> > So that should be safe to use right?
>
> Yes.
>
> > Otherwise would making register_multiwrite accept a void* pointer be better?
>
> Yeah it would. The argument type is wrong. If the function uses
> memcpy_foo it expects an u8 array (or void array, whatever you prefer).
Ok, thanks. I'll fix this as soon as possible.
Ivo
prev parent reply other threads:[~2007-02-28 18:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 14:07 [PATCH 8/28] rt2x00: optimize mac/bssid writing Ivo van Doorn
2007-02-28 17:36 ` Michael Buesch
2007-02-28 18:15 ` Ivo van Doorn
2007-02-28 18:24 ` Michael Buesch
2007-02-28 18:30 ` Ivo van Doorn
2007-02-28 18:46 ` Michael Buesch
2007-02-28 18:48 ` Ivo van Doorn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702281948.00464.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.