From: David Miller <davem@davemloft.net>
To: shemminger@linux-foundation.org
Cc: akpm@linux-foundation.org, netdev@vger.kernel.org,
bugme-daemon@bugzilla.kernel.org, loveminix@yahoo.com.cn,
khc@pm.waw.pl
Subject: Re: [Bugme-new] [Bug 8107] New: dev->header_cache_update has a random value
Date: Thu, 01 Mar 2007 17:33:10 -0800 (PST) [thread overview]
Message-ID: <20070301.173310.74748069.davem@davemloft.net> (raw)
In-Reply-To: <20070301143727.4ba00d04@freekitty>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Thu, 1 Mar 2007 14:37:27 -0800
> Not necessary, since any network device must already allocated by
> alloc_netdev() and it initializes the whole struct to 0 (NULL).
It is in this case, unfortunately, HDLC protocols can be registers
several times before the device is brought up and protocol changes
become disallowed.
So you can attach one, then a second one, and the second one has
to explicitly initialize the pointers potentially set by the
first one.
On the other hand, you could say that it's the protocol
->detach() method's responsibility to NULL out these things
instead of leaving references to function pointers of
a module that's about the be unloaded.
next prev parent reply other threads:[~2007-03-02 1:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200703011933.l21JX5hw018666@fire-2.osdl.org>
2007-03-01 22:34 ` [Bugme-new] [Bug 8107] New: dev->header_cache_update has a random value Andrew Morton
2007-03-01 22:37 ` Stephen Hemminger
2007-03-01 22:54 ` Andrew Morton
2007-03-01 23:30 ` Stephen Hemminger
2007-03-02 1:38 ` David Miller
2007-03-02 1:33 ` David Miller [this message]
2007-03-02 15:29 ` Krzysztof Halasa
2007-03-02 19:23 ` David Miller
2007-03-02 23:38 ` Krzysztof Halasa
2007-03-02 23:43 ` David Miller
2007-03-02 23:38 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070301.173310.74748069.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=khc@pm.waw.pl \
--cc=loveminix@yahoo.com.cn \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.