From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Thu, 1 Mar 2007 07:08:53 +0100 Subject: [U-Boot-Users] error: `CFG_RTC_BUS_NUM' undeclared In-Reply-To: <20070228182147.7a4d326c.kim.phillips@freescale.com> References: <20070228182147.7a4d326c.kim.phillips@freescale.com> Message-ID: <200703010708.54294.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Kim, On Thursday 01 March 2007 01:21, Kim Phillips wrote: > The code introduced with your patch "[PATCH] I2C: Add support for multiple > I2C busses for RTC & DTT": > > http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=0dc018ece >13effc689e47479ea9ebf1c98a507f5 > > breaks board builds that don't define CFG_RTC_BUS_NUM but do define > CFG_CMD_DATE (such as the MPC8349EMDS): > > cmd_date.c: In function `do_date': > cmd_date.c:52: error: `CFG_RTC_BUS_NUM' undeclared (first use in this > function) Ups. Sorry. > CFG_RTC_BUS_NUM needs to either be protected, or forced to 0 if undefined, > or even enforce that all boards that define CMD_DATE also define the RTC > bus. Let me know how you want to proceed. How about this (I'll forward this patch today to Wolfgang): [PATCH] I2C: Add missing default CFG_RTC_BUS_NUM & CFG_DTT_BUS_NUM Signed-off-by: Stefan Roese --- commit 8c12045a3b06c5b6675d3fe02fbc9f545988129a tree 1be6aa3d773a9dddb80655f66ad95aee054d618c parent 743571145b37182757d4e688a77860b36ee77573 author Stefan Roese Thu, 01 Mar 2007 07:03:25 +0100 committer Stefan Roese Thu, 01 Mar 2007 07:03:25 +0100 include/i2c.h | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/include/i2c.h b/include/i2c.h index 54c6f9f..d31c72d 100644 --- a/include/i2c.h +++ b/include/i2c.h @@ -56,6 +56,14 @@ #define I2C_SET_BUS(a) #endif +/* define the I2C bus number for RTC and DTT if not already done */ +#if !defined(CFG_RTC_BUS_NUM) +#define CFG_RTC_BUS_NUM 0 +#endif +#if !defined(CFG_DTT_BUS_NUM) +#define CFG_DTT_BUS_NUM 0 +#endif + /* * Initialization, must be called once on start up, may be called * repeatedly to change the speed and slave addresses.