Re: [PATCH] OMAP2 camera and TCM825x sensor drivers

[tony@atomide.com]

* Trilok Soni <soni.trilok@gmail.com> [070228 21:50]:
> Syed,
> 
> On 2/28/07, Syed Mohammed, Khasim <x0khasim@ti.com> wrote:
> >If some patches are for review please mark them as "RFC". "Patch" is
> >when it has to go into tree - Some one can correct me if I am wrong.
> >
> >Sakari,
> >
> >Thanks for the code, do you have any kind of design doc or ppt that
> >gives a brief overview of what the code is and the interface considered
> >etc. Its bit hard to go directly to code :(
> 
> I don't think that you will need this. What interface you would like
> to understand? Please phrase the questions based on the code and may
> Sakari can help you to understand :) I believe some of the changes in
> N800 camera driver was also done to reduce the interrupt latencies and
> bugs in video-buf.

I agree with Trilok. The idea is to do incremental changes based on
patches.

> >The second issue is merging TI's camera code with this. I can post our
> >design considerations for camera. We can see how to integrate TIs sensor
> >and additional functionality provided by TI's camera code (like
> >rotation, scatter gather dma, multiple sensors handling etc).
> 
> Do you mean "rotation" of the preview window ? See, preview in camera
> driver is just a add-on functionality _but_ not must. I would not use
> this auto preview functionality, instead captured stream will go to
> /dev/fb1 and then shown on the LCD/TV out and rotated based on the
> N800 sensor or app commands.

Yyp, additional features are easy to add later once we have basics
in place.

Regards,

Tony