From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: support@coraid.com, "Ed L. Cashin" <ecashin@coraid.com>,
linux-kernel@vger.kernel.org, Greg KH <greg@kroah.com>
Subject: Re: PATCH 2.6.21-rc1 aoe: handle zero _count pages in bios
Date: Thu, 1 Mar 2007 21:00:44 -0800 [thread overview]
Message-ID: <20070301210044.d95bcd70.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070302044910.GA22209@infradead.org>
On Fri, 2 Mar 2007 04:49:10 +0000 Christoph Hellwig <hch@infradead.org> wrote:
> On Thu, Mar 01, 2007 at 08:48:06PM -0800, Andrew Morton wrote:
> > On Fri, 2 Mar 2007 04:30:39 +0000 Christoph Hellwig <hch@infradead.org> wrote:
> >
> > > But in this case we'd really need to enforce this, and add a
> > > BUG_ON(PageSlab(page)) in bio_add_page to trip everyone submit
> > > this kind of pages.
> >
> > That would be
> >
> > BUG_ON(PageSlab(page) && page_count(page) == 0)?
>
> No, all slab pages. Currently they all have a reference count of
> zero, but we generally don't want people to pass in pages that
> come from a non-refcounted allocator.
I that case we're talking about different things.
I thought the proposal was to continue to use slab pages, but to take a ref
on them as they're added to the bio, drop that ref in bi_end_io()?
next prev parent reply other threads:[~2007-03-02 5:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-01 23:15 PATCH 2.6.21-rc1 aoe: handle zero _count pages in bios Ed L. Cashin
2007-03-02 1:42 ` Andrew Morton
2007-03-02 2:29 ` Christoph Hellwig
2007-03-02 3:22 ` Andrew Morton
2007-03-02 4:30 ` Christoph Hellwig
2007-03-02 4:48 ` Andrew Morton
2007-03-02 4:49 ` Christoph Hellwig
2007-03-02 5:00 ` Andrew Morton [this message]
2007-03-02 5:03 ` Christoph Hellwig
2007-03-02 5:09 ` Andrew Morton
2007-03-02 5:15 ` Christoph Hellwig
2007-03-02 15:51 ` Sam Hopkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070301210044.d95bcd70.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ecashin@coraid.com \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=support@coraid.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.