From: "John W. Linville" <linville@tuxdriver.com>
To: Pavel Roskin <proski@gnu.org>
Cc: linux-wireless@vger.kernel.org, bcm43xx-dev@lists.berlios.de
Subject: Re: Assertion failed in ieee80211softmac_wx_get_rate
Date: Fri, 2 Mar 2007 08:57:34 -0500 [thread overview]
Message-ID: <20070302135734.GB6676@tuxdriver.com> (raw)
In-Reply-To: <1172816819.26330.12.camel@dv>
On Fri, Mar 02, 2007 at 01:26:59AM -0500, Pavel Roskin wrote:
> Hello!
>
> If I load bcm43xx and run iwconfig without bringing the interface up,
> I'm getting this in the kernel log:
>
> SoftMAC: ASSERTION FAILED (0)
> at: /home/proski/src/linux-2.6/net/ieee80211/softmac/ieee80211softmac_wx.c:306:ieee80211softmac_wx_get_rate()
>
> It's an x86 system with the 2.6.20 kernel (actually, it's the master
> branch from the mb repository, which is wireless-dev before the 2.6.21
> switchover plus broadcom fixes).
>
> The assert assures that the interface has a valid tx rate. But since
> the interface has never been up, the rate has not been assigned.
>
> Either softmac should tolerate rate 0, at least when the interface is
> down, or it should initialize the rate much earlier, perhaps in
> alloc_ieee80211softmac().
>
> I can test another tree, e.g. wireless-2.6, if there are chances that
> the problem has been fixed.
Does the tree you are using have this commit?
commit 6bbdce5ac755e3b3cdcf9bb9fdbcc2af78ad34d0
Author: John W. Linville <linville@tuxdriver.com>
Date: Tue Jan 2 21:22:05 2007 -0500
[PATCH] softmac: avoid assert in ieee80211softmac_wx_get_rate
Unconfigured bcm43xx device can hit an assert() during wx_get_rate
queries. This is because bcm43xx calls ieee80211softmac_start late
(i.e. during open instead of probe).
bcm43xx_net_open ->
bcm43xx_init_board ->
bcm43xx_select_wireless_core ->
ieee80211softmac_start
Fix is to check that device is running before completing
ieee80211softmac_wx_get_rate.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
It is in linux-2.6, wireless-2.6, and wireless-dev. If you don't
want to use those trees, you should be able to apply the patch to
the tree you are using.
Hth!
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-03-02 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-02 6:26 Assertion failed in ieee80211softmac_wx_get_rate Pavel Roskin
2007-03-02 13:57 ` John W. Linville [this message]
2007-03-02 16:28 ` Pavel Roskin
2007-03-02 17:23 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070302135734.GB6676@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.