From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
john stultz <johnstul@us.ibm.com>,
Roman Zippel <zippel@linux-m68k.org>,
Christian Borntraeger <cborntra@de.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] timer/hrtimer: take per cpu locks in sane order
Date: Fri, 2 Mar 2007 22:39:59 +0100 [thread overview]
Message-ID: <20070302213959.GA9514@osiris.ibm.com> (raw)
In-Reply-To: <20070302114524.1c61cf22.akpm@linux-foundation.org>
> > +/*
> > + * double_timer_lock/unlock are used to ensure that on cpu hotplug the
> > + * per cpu timer locks are always taken in the same order.
> > + */
> > +static void __devinit double_timer_lock(tvec_base_t *base1,
> > + tvec_base_t *base2, int ind)
> > + __acquires(base1->lock)
> > + __acquires(base2->lock)
>
> hm. Can we not just pass in the spinlock_t*'s and use a common function?
>
> void double_spin_lock(spinlock_t *l1, spinlock_t *l2, int ind);
>
> that way it has nothing to do with timers and can potentially be used
> elsewhere in the kernel, too.
>
> (what does "ind" mean?)
Sure. Will put a static inline function into include/linux/spinlock.h.
"ind" is supposed to be the short form of "indicator".
next prev parent reply other threads:[~2007-03-02 21:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-27 15:30 timer/hrtimer & cpu hotplug lockdep complaints Heiko Carstens
2007-03-02 12:58 ` [patch] timer/hrtimer: take per cpu locks in sane order Heiko Carstens
2007-03-02 13:04 ` Ingo Molnar
2007-03-02 14:23 ` Heiko Carstens
2007-03-02 16:48 ` Andrew Morton
2007-03-02 19:08 ` Heiko Carstens
2007-03-02 19:45 ` Andrew Morton
2007-03-02 21:39 ` Heiko Carstens [this message]
2007-03-02 22:47 ` Heiko Carstens
2007-03-04 23:24 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070302213959.GA9514@osiris.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cborntra@de.ibm.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.