All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: YOSHIFUJI Hideaki / ???????????? <yoshfuji@linux-ipv6.org>,
	davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] [USBNET] DM9501: Add Corega FEther USB-TXC support.
Date: Fri, 2 Mar 2007 18:41:18 -0800	[thread overview]
Message-ID: <20070303024118.GA7637@kroah.com> (raw)
In-Reply-To: <45E8D083.3010907@garzik.org>

On Fri, Mar 02, 2007 at 08:33:55PM -0500, Jeff Garzik wrote:
> YOSHIFUJI Hideaki / ???????????? wrote:
> >Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> >---
> > drivers/usb/net/dm9601.c |    4 ++++
> > 1 files changed, 4 insertions(+), 0 deletions(-)
> >
> >diff --git a/drivers/usb/net/dm9601.c b/drivers/usb/net/dm9601.c
> >index 4a932e1..c0bc52b 100644
> >--- a/drivers/usb/net/dm9601.c
> >+++ b/drivers/usb/net/dm9601.c
> >@@ -571,6 +571,10 @@ static const struct driver_info dm9601_info = {
> > 
> > static const struct usb_device_id products[] = {
> > 	{
> >+	 USB_DEVICE(0x07aa, 0x9601),	/* Corega FEther USB-TXC */
> >+	 .driver_info = (unsigned long)&dm9601_info,
> >+	 },
> >+	{
> 
> 
> ACK the patch, though I wonder if this shouldn't instead go to Greg.
> 
> Honestly, I would prefer that the USB net drivers were moved into 
> drivers/net with the other net drivers, /then/ I would merge such 
> patches.  We don't add drivers for PCI-based hardware to 
> drivers/pci/net, after all...

I have no objection to that.  Things have been moving out of the
drivers/usb/ directory over time, and if you want to take these under
your umbrella too, that's fine with me.

David, any objections?

thanks,

greg k-h

      reply	other threads:[~2007-03-03  2:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-01  7:44 [PATCH] [USBNET] DM9501: Add Corega FEther USB-TXC support YOSHIFUJI Hideaki / 吉藤英明
2007-03-03  1:33 ` Jeff Garzik
2007-03-03  2:41   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070303024118.GA7637@kroah.com \
    --to=greg@kroah.com \
    --cc=davem@davemloft.net \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.