From: Sam Ravnborg <sam@ravnborg.org>
To: Larry Finger <larry.finger@lwfinger.net>
Cc: Michael Buesch <mb@bu3sch.de>,
linux-wireless@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] bcm43xx: do not rebuild when kernel version changes
Date: Sat, 3 Mar 2007 22:13:32 +0100 [thread overview]
Message-ID: <20070303211332.GA31321@uranus.ravnborg.org> (raw)
In-Reply-To: <45E9E2BD.9070106@lwfinger.net>
On Sat, Mar 03, 2007 at 03:03:57PM -0600, Larry Finger wrote:
> Michael Buesch wrote:
> > On Saturday 03 March 2007 20:03, Sam Ravnborg wrote:
> >> Replacing use of UTS_RELEASE with utsname()->release
> >> avoids that this module is rebuild each
> >> time the kernel version changes.
> >>
> >> Compile tested only.
> >
> > I vote to get rid of the whole bcm43xx_ethtool.c file, as it's useless.
> > It will vanish with the advent of d80211, anyway.
> > Larry?
>
> Is bcm43xx_ethtool.c really useless? If so, I vote to remove it. I have never tried to use ethtool
> on bcm43xx. Similarly, it isn't very often that I recompile the kernel when bcm43xx hasn't changed
> and would not have noticed the bug that Sam reported.
I saw it only because I tossed around with a allmodconfig build.
I do not care if it is fixed one way or the other - but I like that
only relevant parts are rebuild when kernel version changes.
Sam
next prev parent reply other threads:[~2007-03-03 21:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-03 19:03 [PATCH] bcm43xx: do not rebuild when kernel version changes Sam Ravnborg
2007-03-03 20:21 ` Michael Buesch
2007-03-03 21:03 ` Larry Finger
2007-03-03 21:10 ` Michael Buesch
2007-03-03 21:13 ` Sam Ravnborg [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-03-04 5:55 Larry Finger
2007-03-04 12:57 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070303211332.GA31321@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@osdl.org \
--cc=larry.finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.