From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HNc99-0006p9-0j
	for qemu-devel@nongnu.org; Sat, 03 Mar 2007 16:52:07 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HNc97-0006ow-IO
	for qemu-devel@nongnu.org; Sat, 03 Mar 2007 16:52:06 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HNc97-0006ot-Ec
	for qemu-devel@nongnu.org; Sat, 03 Mar 2007 16:52:05 -0500
Received: from phoenix.bawue.net ([193.7.176.60] helo=mail.bawue.net)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1HNc96-0005ub-W8
	for qemu-devel@nongnu.org; Sat, 03 Mar 2007 16:52:05 -0500
Date: Sat, 3 Mar 2007 21:44:58 +0000
Subject: Re: [Qemu-devel] [PATCH] pcnet32 driver change, please test
Message-ID: <20070303214458.GA27476@networkno.de>
References: <20070302200949.GD27636@networkno.de>
	<20070302202913.GE27636@networkno.de>
	<45E8C379.7040903@bellard.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <45E8C379.7040903@bellard.org>
From: Thiemo Seufer <ths@networkno.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fabrice Bellard <fabrice@bellard.org>
Cc: qemu-devel@nongnu.org

Fabrice Bellard wrote:
> Thiemo Seufer wrote:
> >Thiemo Seufer wrote:
> >>Hello All,
> >>
> >>I changed the pcnet32 driver to get rid of bitfields in its
> >>implementation, now it works also on big endian host systems.
> >>
> >>I tested only the 32 bit mode which is used by MIPS/Malta, and
> >>I'm not sure if it still works in Lance mode (as e.g. used on SPARC).
> >>So please test if it still works.
> >
> >I forgot to delete a line of debug output, updated.
> 
> It seems that you made some unnecessary changes (why did you changed the 
> code in pcnet_init ?).

That code currently accesses initblk members (padr. ladrf) after the
initblk structure went out of scope. I also wanted to keep the data
acquisition with its byte swaps in the same place.


Thiemo.