From: Alan Cox <alan@redhat.com>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: alan@redhat.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 2.6.21-rc2] pata_legacy: fix io/irq mismatch
Date: Sat, 3 Mar 2007 17:59:59 -0500 [thread overview]
Message-ID: <20070303225959.GA29420@devserv.devel.redhat.com> (raw)
In-Reply-To: <200703031957.l23JviQQ005254@harpo.it.uu.se>
On Sat, Mar 03, 2007 at 08:57:44PM +0100, Mikael Pettersson wrote:
> pata_legacy fails to detect the disk on my old ISA/VLB 486:
> it starts to probe io=0x1f0 ctr=0x3f6 irq=15, complains
> loudly about IDENTIFYs timing out, and finally fails.
> (Sorry I couldn't capture the kernel's boot messages.)
>
> It turns out that the driver's mapping from io to irq in
> legacy_irq[] is wrong: index 0 for io=0x1f0 has irq=15 but
> should have irq=14, and index 1 for io=0x170 has irq=14 but
> should have irq=15. This is confirmed by a comparison with
> include/asm-i386/ide.h:ide_default_irq().
>
> This patch swaps the first two elements in legacy_irq[],
> which makes pata_legacy work on my 486.
>
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
Acked-by: Alan Cox <alan@redhat.com>
next prev parent reply other threads:[~2007-03-03 23:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-03 19:57 [PATCH 2.6.21-rc2] pata_legacy: fix io/irq mismatch Mikael Pettersson
2007-03-03 22:59 ` Alan Cox [this message]
2007-03-06 9:05 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070303225959.GA29420@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.