From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S933797AbXCFBiy@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933797AbXCFBiy (ORCPT <rfc822;w@1wt.eu>);
	Mon, 5 Mar 2007 20:38:54 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933795AbXCFBiy
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 5 Mar 2007 20:38:54 -0500
Received: from smtp.osdl.org ([65.172.181.24]:45772 "EHLO smtp.osdl.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S933794AbXCFBix (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 5 Mar 2007 20:38:53 -0500
Date: Mon, 5 Mar 2007 17:38:22 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Greg KH <greg@kroah.com>
Cc: Theodore Tso <tytso@mit.edu>, Bron Gondwana <brong@fastmail.fm>,
       Matt Mackall <mpm@selenic.com>, linux-kernel@vger.kernel.org,
       netdev@vger.kernel.org, yi.zhu@intel.com, jketreno@linux.intel.com
Subject: Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)
Message-Id: <20070305173822.d48c4004.akpm@linux-foundation.org>
In-Reply-To: <20070306011709.GA13667@kroah.com>
References: <20070305011625.GA7681@kroah.com>
	<20070305064229.GJ23311@waste.org>
	<20070305070248.GA30699@kroah.com>
	<20070305071325.GK23311@waste.org>
	<20070305154609.GA3626@irc.pl>
	<20070305211425.GR16722@waste.org>
	<20070306002457.GA7078@brong.net>
	<20070306003715.GA12566@kroah.com>
	<20070306005625.GC19634@thunk.org>
	<20070305170849.c042e802.akpm@linux-foundation.org>
	<20070306011709.GA13667@kroah.com>
X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 5 Mar 2007 17:17:09 -0800
Greg KH <greg@kroah.com> wrote:

> On Mon, Mar 05, 2007 at 05:08:49PM -0800, Andrew Morton wrote:
> > On Mon, 5 Mar 2007 19:56:25 -0500
> > Theodore Tso <tytso@mit.edu> wrote:
> > 
> > > So the question really is are we really done making changes to sysfs,
> > > or maybe what we should do is talk about major version numbers to
> > > sysfs.
> > 
> > Perhaps using a config option wasn't the right way to do this - a kernel
> > boot parameter might be better.
> 
> Ok, I have no problem with that if people really want it.  But give me
> the option to also make it a config option so I don't have to change our
> bootloaders too.

Sometimes we provide a config option which provides the default version of
the boot option.  So:

	CONFIG_SYSFS_VERSION=1.2

and

	if (user_provided_sysfs_version == NULL)
		user_provided_sysfs_version = CONFIG_SYSFS_VERSION;


> Does that sound acceptable?

If we make CONFIG_SYSFS_DEPRECATED just a boolean boot option then that
fixes this problem (we hope) but won't help us next time we want to change
something.

It all depends on whether sysfs is finished yet ;)