From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965920AbXCFQy6 (ORCPT ); Tue, 6 Mar 2007 11:54:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965940AbXCFQy5 (ORCPT ); Tue, 6 Mar 2007 11:54:57 -0500 Received: from agminet01.oracle.com ([141.146.126.228]:35004 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965920AbXCFQy4 (ORCPT ); Tue, 6 Mar 2007 11:54:56 -0500 Date: Tue, 6 Mar 2007 08:47:51 -0800 From: Randy Dunlap To: Sergei Shtylyov , htejun@gmail.com Cc: Greg KH , linux-pci@atrey.karlin.mff.cuni.cz, Adrian Bunk , Andrew Morton , Jeff Garzik , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: 2.6.20-rc4-mm1: PCI=n: drivers/net/3c59x.c compile error Message-Id: <20070306084751.b82a7b84.randy.dunlap@oracle.com> In-Reply-To: <45ED9390.3000308@ru.mvista.com> References: <20070111222627.66bb75ab.akpm@osdl.org> <20070124135354.GI17836@stusta.de> <45B76946.1070009@ru.mvista.com> <45D756D7.4060106@ru.mvista.com> <45D75853.1060607@ru.mvista.com> <45E2DF13.9010200@ru.mvista.com> <20070226092644.aea76b37.randy.dunlap@oracle.com> <20070226211401.GC3810@kroah.com> <45ED9390.3000308@ru.mvista.com> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.3.1 (GTK+ 2.8.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Whitelist: TRUE X-Whitelist: TRUE X-Brightmail-Tracker: AAAAAQAAAAI= Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 06 Mar 2007 19:15:12 +0300 Sergei Shtylyov wrote: > Hello. > > Greg KH wrote: > > >>>>>>>3x59x-fix-pci-resource-management.patch causes the following compile > >>>>>>>error with CONFIG_PCI=n: > > >>>>>>><-- snip --> > > >>>>>>>... > >>>>>>> CC drivers/net/3c59x.o > >>>>>>>/home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c: > >>>>>>>In function 'vortex_init_one': > >>>>>>>/home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c:961: > >>>>>>>error: implicit declaration of function 'pci_request_regions' > >>>>>>>/home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c:985: > >>>>>>>error: implicit declaration of function 'pci_release_regions' > >>>>>>>make[3]: *** [drivers/net/3c59x.o] Error 1 > > >>>>>> Grr, at at the same time it's happy with pci_enable_device(). > >>>>>> I'd say the problem is in , not in the patch. > > >>>>> Has there been any patch to fix the "unbalanced" > >>>>>pci_{request|release}_regions() declarations? Am I suposed to create > >>>>>such? > > >>>> Alternatively, vortex_{init|remove_one() and struct pci_driver there > >>>>could have been put under #ifdef CONFIG_PCI (good idea anyway -- should > >>>>reduce driver size on non-PCI systems)... > > >>> I wonder if I may count on any feedback on this -- asking linux-pci now... > >>> The issue is as follows: with my patch pci_{request|release}_regions() may > >>>be called with CONFIG_PCI=n (probably, this never has been a issue before) but > >>> don't have them declared in this case -- unlike > >>>pci_enable_device() which is just empty for CONFIG_PCI=n. > >>> Now, what kind of approach do I take: > > >>>- a "fair one", so that pci_{request|release}_regions() get "balanced" > >>> declarations in the header like pci_enable_device(); > > >>>- a "local one" (and even saving non-PCI kernel from needless bloat), i.e. > >>> #ifdef out functions that are only meaningful with CONFIG_PCI=y)? > > >>> I'm leaning to the second now... > > >>I'd prefer the fair one -- add stubs to include/linux/pci.h. > > > Me too, please just send me a patch adding them to pci.h so you don't > > have to have #ifdefs in your .c code. > > Erm, before I do that, could somebody explain what > > #define HAVE_PCI_REQ_REGIONS 2 > > accompanying their declaration is for? I have't found any references to it in > the source. Should I duplicate it for CONFIG_PCI=n case (I guess not)? I wouldn't since it's not used anywhere, but maybe Tejun could comment on it... --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***