From mboxrd@z Thu Jan 1 00:00:00 1970 From: Len Brown Subject: Re: [patch 2/6] drivers/cpuidle/: make code static Date: Wed, 7 Mar 2007 03:02:03 -0500 Message-ID: <200703070302.03923.lenb@kernel.org> References: <200703061029.l26ATeKJ019119@shell0.pdx.osdl.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from hera.kernel.org ([140.211.167.34]:57685 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964969AbXCGIG2 (ORCPT ); Wed, 7 Mar 2007 03:06:28 -0500 In-Reply-To: <200703061029.l26ATeKJ019119@shell0.pdx.osdl.net> Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: akpm@linux-foundation.org Cc: linux-acpi@vger.kernel.org, bunk@stusta.de, abelay@novell.com, shaohua.li@intel.com, venkatesh.pallipadi@intel.com Applied. thanks, -Len On Tuesday 06 March 2007 05:29, akpm@linux-foundation.org wrote: > From: Adrian Bunk > > This patch makes the following needlessly global code static: > - driver.c: __cpuidle_find_driver() > - governor.c: __cpuidle_find_governor() > - ladder.c: struct ladder_governor > > Signed-off-by: Adrian Bunk > Cc: Len Brown > Cc: Venkatesh Pallipadi > Cc: Adam Belay > Cc: Shaohua Li > Signed-off-by: Andrew Morton > --- > > drivers/cpuidle/cpuidle.h | 2 -- > drivers/cpuidle/driver.c | 2 +- > drivers/cpuidle/governor.c | 2 +- > drivers/cpuidle/governors/ladder.c | 2 +- > 4 files changed, 3 insertions(+), 5 deletions(-) > > diff -puN drivers/cpuidle/cpuidle.h~drivers-cpuidle-make-code-static drivers/cpuidle/cpuidle.h > --- a/drivers/cpuidle/cpuidle.h~drivers-cpuidle-make-code-static > +++ a/drivers/cpuidle/cpuidle.h > @@ -23,13 +23,11 @@ extern void cpuidle_rescan_device(struct > /* drivers */ > extern int cpuidle_attach_driver(struct cpuidle_device *dev); > extern void cpuidle_detach_driver(struct cpuidle_device *dev); > -extern struct cpuidle_driver * __cpuidle_find_driver(const char *str); > extern int cpuidle_switch_driver(struct cpuidle_driver *drv); > > /* governors */ > extern int cpuidle_attach_governor(struct cpuidle_device *dev); > extern void cpuidle_detach_governor(struct cpuidle_device *dev); > -extern struct cpuidle_governor * __cpuidle_find_governor(const char *str); > extern int cpuidle_switch_governor(struct cpuidle_governor *gov); > > /* sysfs */ > diff -puN drivers/cpuidle/driver.c~drivers-cpuidle-make-code-static drivers/cpuidle/driver.c > --- a/drivers/cpuidle/driver.c~drivers-cpuidle-make-code-static > +++ a/drivers/cpuidle/driver.c > @@ -73,7 +73,7 @@ void cpuidle_detach_driver(struct cpuidl > * > * Must be called with cpuidle_lock aquired. > */ > -struct cpuidle_driver * __cpuidle_find_driver(const char *str) > +static struct cpuidle_driver * __cpuidle_find_driver(const char *str) > { > struct cpuidle_driver *drv; > > diff -puN drivers/cpuidle/governor.c~drivers-cpuidle-make-code-static drivers/cpuidle/governor.c > --- a/drivers/cpuidle/governor.c~drivers-cpuidle-make-code-static > +++ a/drivers/cpuidle/governor.c > @@ -72,7 +72,7 @@ void cpuidle_detach_governor(struct cpui > * > * Must be called with cpuidle_lock aquired. > */ > -struct cpuidle_governor * __cpuidle_find_governor(const char *str) > +static struct cpuidle_governor * __cpuidle_find_governor(const char *str) > { > struct cpuidle_governor *gov; > > diff -puN drivers/cpuidle/governors/ladder.c~drivers-cpuidle-make-code-static drivers/cpuidle/governors/ladder.c > --- a/drivers/cpuidle/governors/ladder.c~drivers-cpuidle-make-code-static > +++ a/drivers/cpuidle/governors/ladder.c > @@ -199,7 +199,7 @@ static void ladder_exit_device(struct cp > kfree(dev->governor_data); > } > > -struct cpuidle_governor ladder_governor = { > +static struct cpuidle_governor ladder_governor = { > .name = "ladder", > .init = ladder_init_device, > .exit = ladder_exit_device, > _ >