From: Patrick McHardy <kaber@trash.net>
To: stable@kernel.org
Cc: netfilter-devel@lists.netfilter.org,
Patrick McHardy <kaber@trash.net>,
davem@davemloft.net
Subject: [NETFILTER 13/13]: nfnetlink_log: fix crash on bridged packet
Date: Wed, 7 Mar 2007 22:34:45 +0100 (MET) [thread overview]
Message-ID: <20070307213405.22306.94073.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20070307213347.22306.9248.sendpatchset@localhost.localdomain>
[NETFILTER]: nfnetlink_log: fix crash on bridged packet
physoutdev is only set on purely bridged packet, when nfnetlink_log is used
in the OUTPUT/FORWARD/POSTROUTING hooks on packets forwarded from or to a
bridge it crashes when trying to dereference skb->nf_bridge->physoutdev.
Reported by Holger Eitzenberger <heitzenberger@astaro.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
commit f6b1560a99c15c4a36c891d576fadb017b12da58
tree a2db90ece908c7334c5a8167cfdf36e8aefedc4f
parent 80124a592479a1730fde6fb370c80d705d889ce3
author Patrick McHardy <kaber@trash.net> Tue, 06 Mar 2007 08:31:57 +0100
committer Patrick McHardy <kaber@trash.net> Tue, 06 Mar 2007 08:31:57 +0100
net/netfilter/nfnetlink_log.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c
index 5675d2d..60d821f 100644
--- a/net/netfilter/nfnetlink_log.c
+++ b/net/netfilter/nfnetlink_log.c
@@ -486,7 +486,7 @@ #else
* for physical device (when called from ipv4) */
NFA_PUT(inst->skb, NFULA_IFINDEX_OUTDEV,
sizeof(tmp_uint), &tmp_uint);
- if (skb->nf_bridge) {
+ if (skb->nf_bridge && skb->nf_bridge->physoutdev) {
tmp_uint =
htonl(skb->nf_bridge->physoutdev->ifindex);
NFA_PUT(inst->skb, NFULA_IFINDEX_PHYSOUTDEV,
prev parent reply other threads:[~2007-03-07 21:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 21:34 [NETFILTER 00/13]: Netfilter -stable fixes Patrick McHardy
2007-03-07 21:34 ` [NETFILTER 01/13]: conntrack: fix {nf, ip}_ct_iterate_cleanup endless loops Patrick McHardy
2007-03-07 21:34 ` [NETFILTER 02/13]: nf_conntrack/nf_nat: fix incorrect config ifdefs Patrick McHardy
2007-03-07 21:34 ` [NETFILTER 03/13]: tcp conntrack: accept SYN|URG as valid Patrick McHardy
2007-03-07 21:34 ` [NETFILTER 04/13]: nfnetlink_log: fix reference leak Patrick McHardy
2007-03-07 21:34 ` [NETFILTER 05/13]: nfnetlink_log: fix use after free Patrick McHardy
2007-03-07 21:34 ` [NETFILTER 06/13]: nfnetlink_log: fix NULL pointer dereference Patrick McHardy
2007-03-07 21:34 ` [NETFILTER 07/13]: nfnetlink_log: fix possible " Patrick McHardy
2007-03-07 21:34 ` [NETFILTER 08/13]: nfnetlink_log: fix module reference counting Patrick McHardy
2007-03-07 21:34 ` [NETFILTER 09/13]: nfnetlink_log: fix " Patrick McHardy
2007-03-10 5:15 ` [stable] " Greg KH
2007-03-07 21:34 ` [NETFILTER 10/13]: ip6_route_me_harder should take into account mark Patrick McHardy
2007-03-07 21:34 ` [NETFILTER 11/13]: nf_conntrack: fix incorrect classification of IPv6 fragments as ESTABLISHED Patrick McHardy
2007-03-07 21:34 ` [NETFILTER 12/13]: nfnetlink_log: zero-terminate prefix Patrick McHardy
2007-03-07 21:34 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070307213405.22306.94073.sendpatchset@localhost.localdomain \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.