All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Christoph Hellwig <hch@infradead.org>,
	Deepak Saxena <dsaxena@plexity.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix building kernel under Solaris
Date: Thu, 8 Mar 2007 08:35:43 +0000	[thread overview]
Message-ID: <20070308083543.GA5213@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0703072342310.2448@yvahk01.tjqt.qr>

On Wed, Mar 07, 2007 at 11:45:11PM +0100, Jan Engelhardt wrote:
> 
> On Mar 7 2007 09:42, Christoph Hellwig wrote:
> >>  #include <sys/time.h>
> >>  #include <sys/ioctl.h>
> >>  #include <sys/types.h>
> >> +#ifndef __sun__
> >>  #include <asm/types.h>
> >>  #endif
> >> +#endif
> >
> >So if solaris doesn't need it, why do we need it on Linux?
> 
> For __s32 and __s16.

We shouldn't use those from asm/types.h on Linux either, but
get them consitantly by defining them to the C99 or BSD types
from the libc headers.

  reply	other threads:[~2007-03-08  8:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-06 18:09 [PATCH] Fix building kernel under Solaris Deepak Saxena
2007-03-06 18:22 ` Deepak Saxena
2007-03-06 19:23 ` Sam Ravnborg
2007-03-07  9:42 ` Christoph Hellwig
2007-03-07 22:45   ` Jan Engelhardt
2007-03-08  8:35     ` Christoph Hellwig [this message]
2007-03-08 20:43       ` Jan Engelhardt
2007-03-08 21:25         ` Sam Ravnborg
2007-03-08 22:01           ` [PATCH] Fix building kernel under Solaris 11_snv Jan Engelhardt
2007-03-09 19:00             ` Sam Ravnborg
2007-03-09 20:16               ` Jan Engelhardt
2007-03-09 22:23                 ` Sam Ravnborg
2007-03-09 22:55                   ` Jan Engelhardt
2007-03-10  9:37                   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070308083543.GA5213@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=dsaxena@plexity.net \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.