Re: [PATCH 1/9] lguest: block device speedup

[Jens Axboe <jens.axboe@oracle.com>]

On Fri, Mar 09 2007, Christoph Hellwig wrote:
> On Fri, Mar 09, 2007 at 02:05:24PM +1100, Rusty Russell wrote:
> > diff -r fdc8cbc1fd61 drivers/block/lguest_blk.c
> > --- a/drivers/block/lguest_blk.c	Thu Mar 08 13:35:39 2007 +1100
> > +++ b/drivers/block/lguest_blk.c	Thu Mar 08 15:51:55 2007 +1100
> > @@ -45,6 +45,16 @@ struct blockdev
> >  	struct request *req;
> >  };
> >  
> > +/* Jens gave me this nice helper to end all chunks of a request. */
> > +static void end_entire_request(struct request *req, int uptodate)
> > +{
> > +	if (end_that_request_first(req, uptodate, req->hard_nr_sectors))
> > +		BUG();
> > +	add_disk_randomness(req->rq_disk);
> > +	blkdev_dequeue_request(req);
> > +	end_that_request_last(req, uptodate);
> > +}
> 
> I think we really want this in common code, ll_rw_blk.c should have:

Yeah I know, this is also what I wrote to Rusty when I reviewed this
code and made the suggestion. The kernel also needs a full sweep to get
rid of end_request() entirely, it's really a relic from ancient times.

-- 
Jens Axboe