From: Christoph Hellwig <hch@infradead.org>
To: Judith Lebzelter <judith@linux-foundation.org>
Cc: linux-scsi@vger.kernel.org, mpt_linux_developer@lsi.com,
Eric.Moore@lsi.com, James.Bottomley@SteelEye.com
Subject: Re: [ PATCH ] mptsas: Fix oops for insmod during kexec
Date: Fri, 9 Mar 2007 21:22:37 +0000 [thread overview]
Message-ID: <20070309212237.GA25326@infradead.org> (raw)
In-Reply-To: <20070309210744.GD1006@shell0.pdx.osdl.net>
On Fri, Mar 09, 2007 at 01:07:44PM -0800, Judith Lebzelter wrote:
> Hello,
>
> This patch is to fix an oops on insmod for mptsas during kexec.
> This applies to 2.6.21-rc3.
>
> Signed-off-by: Judith Lebzelter <judith@osdl.org
>
> ---
>
>
> Index: linux-2.6.21-rc3/drivers/message/fusion/mptsas.c
> ===================================================================
> --- linux-2.6.21-rc3.orig/drivers/message/fusion/mptsas.c
> +++ linux-2.6.21-rc3/drivers/message/fusion/mptsas.c
> @@ -815,7 +815,7 @@ mptsas_taskmgmt_complete(MPT_ADAPTER *io
> static int
> mptsas_ioc_reset(MPT_ADAPTER *ioc, int reset_phase)
> {
> - MPT_SCSI_HOST *hd = (MPT_SCSI_HOST *)ioc->sh->hostdata;
> + MPT_SCSI_HOST *hd;
> struct mptsas_target_reset_event *target_reset_list, *n;
> int rc;
>
> @@ -827,7 +827,10 @@ mptsas_ioc_reset(MPT_ADAPTER *ioc, int r
> if (reset_phase != MPT_IOC_POST_RESET)
> goto out;
>
> - if (!hd || !hd->ioc)
> + if (!ioc->sh || !ioc->sh->hostdata)
> + goto out;
> + hd = (MPT_SCSI_HOST *)ioc->sh->hostdata;
> + if (!hd->ioc)
This needs a much better explanation. Please show the codepath
leading to this.
next prev parent reply other threads:[~2007-03-09 21:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 21:07 [ PATCH ] mptsas: Fix oops for insmod during kexec Judith Lebzelter
2007-03-09 21:22 ` Christoph Hellwig [this message]
2007-03-09 22:22 ` Moore, Eric
2007-03-10 9:26 ` Christoph Hellwig
2007-03-12 22:14 ` [ PATCH ] mptsas: Fix oops during driver load time(rev 2) Judith Lebzelter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070309212237.GA25326@infradead.org \
--to=hch@infradead.org \
--cc=Eric.Moore@lsi.com \
--cc=James.Bottomley@SteelEye.com \
--cc=judith@linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mpt_linux_developer@lsi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.