From: Len Brown <lenb@kernel.org>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH][RFC] Make entire ACPI submenu dependent on PM.
Date: Fri, 9 Mar 2007 22:26:14 -0500 [thread overview]
Message-ID: <200703092226.14552.lenb@kernel.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0703041312490.5332@CPE00045a9c397f-CM001225dbafb6>
This patch is right, and I applied it.
On i386, it did what it should -- made the menus look better.
Testing x86_64 exposed a latent bug, however.
Since CONFIG_X86_64_ACPI_NUMA=y does a select on ACPI,
it is possible to config a kernel with PM=n
and ACPI=y, which violates ACPI's dependency on PM.
Basically, select of something that has dependencies doesn't
enforce those dependencies.
When will somebody re-write Kconfig into something that
humans can use?
-Len
On Sunday 04 March 2007 13:17, Robert P. J. Day wrote:
>
> Make the visibility of the entire ACPI submenu dependent on PM.
>
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
>
> ---
>
> given that de-selecting Power Management (PM) de-activates the
> entire contents of the ACPI submenu, it seems pointless to leave the
> top-level menu entry visible. but this is just a hack and i'll leave
> it to the official maintainers to do it properly. :-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 7c49e10..3208ce0 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -7,6 +7,7 @@ menu "ACPI (Advanced Configuration and Power Interface) Support"
> depends on !X86_VISWS
> depends on !IA64_HP_SIM
> depends on IA64 || X86
> + depends on PM
>
> config ACPI
> bool "ACPI Support"
>
prev parent reply other threads:[~2007-03-10 3:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-04 18:17 [PATCH][RFC] Make entire ACPI submenu dependent on PM Robert P. J. Day
2007-03-10 3:26 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703092226.14552.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.