From: Andrew Morton <akpm@linux-foundation.org>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: linux-kernel@vger.kernel.org, twoller@crystal.cirrus.com
Subject: Re: [PATCH] CIRRUS: Delete unused header file.
Date: Sat, 10 Mar 2007 23:26:10 -0800 [thread overview]
Message-ID: <20070310232610.dda68aff.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0703101725550.28973@CPE00045a9c397f-CM001225dbafb6>
> On Sat, 10 Mar 2007 17:27:44 -0500 (EST) "Robert P. J. Day" <rpjday@mindspring.com> wrote:
>
> Delete apparently unused header file
> sound/pci/cs46xx/imgs/cwcemb80.h.
>
That patch series was rather a mess
- Multiple patches with the same Subject: (I might have lost some as a result)
- Several patches which tried to remove the same header file
- Several patches which simply didn't apply
- Inconsisent changelogging, inconsistent titling
- Lack of sequence numbering (again, contributes to possible patch loss)
- Useless indenting in changleog text which I have to edit away.
We have good tools (ie: quilt) which make this sort of thing nice and easy
to get right - please use them.
I didn't check that these headers are indeed unused. I hope you got that
minor part right..
next prev parent reply other threads:[~2007-03-11 7:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-10 22:27 [PATCH] CIRRUS: Delete unused header file Robert P. J. Day
2007-03-11 7:26 ` Andrew Morton [this message]
2007-03-11 10:09 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070310232610.dda68aff.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
--cc=twoller@crystal.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.