Re: _proxy_pda still makes linking modules fail

[Andi Kleen <andi@firstfloor.org>]

On Sun, Mar 11, 2007 at 05:25:46PM -0700, Jeremy Fitzhardinge wrote:
> Andi Kleen wrote:
> > Hmm, it probably needs a EXPORT_SYMBOL. The previous change only
> > fixed the in kernel build.
> >
> > Does it work with this patch?
> >
> > -Andi
> >
> > Export _proxy_pda for gcc 4.2
> >   
> 
> Gak.  It seemed like such a good idea at the time.

The problem is that the upcomming 4.2 has a more aggressive optimizer
and when there are two "m" (_proxy_pda...) references in the same
function it CSEs its address into a register. And that generates
code and a reference.

> 
> Rusty's pda->per_cpu patch will deal with this once and for all; have

Not on x86-64.

> you picked it up yet?

Not yet.

-Andi