From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 4/4] Replace fork_with_pipe in bundle with run_command
Date: Mon, 12 Mar 2007 20:36:47 -0400 [thread overview]
Message-ID: <20070313003646.GA17169@spearce.org> (raw)
In-Reply-To: <7vslcaow13.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
> "Shawn O. Pearce" <spearce@spearce.org> writes:
> > return status;
>
> As the variable 'status' is not used anymore, I think this should return 0.
Indeed. I replaced that patch with another (same subject) in my
latest series. Because leaving that 'status' variable in caused
a failure in the test suite when trying to create a bundle.
fixed: http://article.gmane.org/gmane.comp.version-control.git/42087
borked: http://article.gmane.org/gmane.comp.version-control.git/42056
You quoted the borked one. Please drop it and apply the fixed one.
--
Shawn.
next prev parent reply other threads:[~2007-03-13 0:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 18:38 [PATCH 4/4] Replace fork_with_pipe in bundle with run_command Shawn O. Pearce
2007-03-12 23:57 ` Junio C Hamano
2007-03-13 0:36 ` Shawn O. Pearce [this message]
2007-03-13 0:54 ` Junio C Hamano
2007-03-13 0:56 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070313003646.GA17169@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.