All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Deegan <Tim.Deegan@xensource.com>
To: "Woller, Thomas" <thomas.woller@amd.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: Cs/ 14346 breaks 64bit hv
Date: Wed, 14 Mar 2007 09:34:04 +0000	[thread overview]
Message-ID: <20070314093404.GA2351@york.uk.xensource.com> (raw)
In-Reply-To: <683860AD674C7348A0BF0DE3918482F6048FB5F7@SAUSEXMB1.amd.com>

At 01:47 -0500 on 14 Mar (1173836821), Woller, Thomas wrote:
> Took a look at the rombios.s code generated in both cases (14344 and
> 14345) and seems like the "jump to the boot vector" code is not executed
> on the failing case.  There is a "default: return" in the function
> immediately above an "#if BX_TCGBIOS", and then the non-executed asm
> code. 
> Is bcc not understanding that the asm code following should be executed?
> Seems like there is added a default "return" so that the "jump to boot
> vector" code is never executed?  appears to be the case..but not sure.  

That would be terrifying.  Presumably there's a jmp past that ret
somewhere.  I got the impression from your first email that some
guests do boot, and that can only happen through that iret. 

Does adding an explicit "return;" in C after the asm block change the
behaviour?

> Code snippets are below.  Using gcc 3.3.5, but will try 4.x compiler,
> although looks like bcc is used to generate the rombios.s file if I read
> the Makefile correctly.

Yep.  What version of bcc are you using? (bcc -v says 0.16.14 for me)

Cheers,

Tim.

-- 
Tim Deegan <Tim.Deegan@xensource.com>, XenSource UK Limited
Registered office c/o EC2Y 5EB, UK; company number 05334508

  reply	other threads:[~2007-03-14  9:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-13 23:01 Cs/ 14346 breaks 64bit hv Woller, Thomas
2007-03-14  6:47 ` Woller, Thomas
2007-03-14  9:34   ` Tim Deegan [this message]
2007-03-14  9:56     ` Tim Deegan
2007-03-14 15:00     ` Woller, Thomas
2007-03-14 15:57       ` Keir Fraser
2007-03-14 16:54       ` Tim Deegan
2007-03-14 17:14         ` Woller, Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070314093404.GA2351@york.uk.xensource.com \
    --to=tim.deegan@xensource.com \
    --cc=thomas.woller@amd.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.