From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422888AbXCOPQ6 (ORCPT ); Thu, 15 Mar 2007 11:16:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422889AbXCOPQ6 (ORCPT ); Thu, 15 Mar 2007 11:16:58 -0400 Received: from mail.kroah.org ([69.55.234.183]:55156 "EHLO perch.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422888AbXCOPQ5 (ORCPT ); Thu, 15 Mar 2007 11:16:57 -0400 Date: Thu, 15 Mar 2007 07:54:14 -0700 From: Greg KH To: Mike Galbraith Cc: Andrew Morton , Tejun Heo , Kay Sievers , linux-kernel@vger.kernel.org, Adrian Bunk Subject: Re: kref refcounting breakage in mainline Message-ID: <20070315145414.GA18542@kroah.com> References: <20070302005833.949be737.akpm@linux-foundation.org> <20070306002521.GA12164@kroah.com> <1173159802.6955.6.camel@Homer.simpson.net> <20070306210445.GB29164@kroah.com> <1173245937.6613.26.camel@Homer.simpson.net> <1173541446.6561.32.camel@Homer.simpson.net> <20070315052724.GA12576@kroah.com> <1173945187.6624.14.camel@Homer.simpson.net> <20070315080639.GA14641@kroah.com> <1173953960.6624.45.camel@Homer.simpson.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1173947546.6624.29.camel@Homer.simpson.net> <1173953960.6624.45.camel@Homer.simpson.net> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 15, 2007 at 11:19:20AM +0100, Mike Galbraith wrote: > On Thu, 2007-03-15 at 01:06 -0700, Greg KH wrote: > > > That's good. But why don't we have a module name for this driver? > > > > And if we don't have a module name, why would there be a symlink to > > remove? That's what is keeping your module from unloading, right? > > You keep saying "module", and that's making me a bit nervous ;-) > > Just to be sure we're not talking past each other, when you say module, > don't mean the modprobe kind... i hope. This "module" as in driver is > compiled in. (said that before, but you may have missed it) Ahh, that changes everything here, thanks for letting me know, I had missed this. The problem is that the module_init() is failing, yet this isn't really a module, it's built into the kernel. So some of the module teardown logic is dieing when it thinks that we really have a full module structure here (owner and such). I'll look at this further tomorrow, as I'm travelling pretty much all day today, sorry. thanks, greg k-h