From: "Vladimir V. Saveliev" <vs@namesys.com>
To: "Nate Diller" <nate.diller@gmail.com>
Cc: reiserfs-dev@namesys.com, "Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] reiser4: page lock recursion in reiser4_write_extent
Date: Thu, 15 Mar 2007 20:34:29 +0300 [thread overview]
Message-ID: <200703152034.29962.vs@namesys.com> (raw)
In-Reply-To: <5c49b0ed0703132240h2087eb12xb44652bf0d235521@mail.gmail.com>
Hello
On Wednesday 14 March 2007 08:40, Nate Diller wrote:
> This little code snippet seems to have a page_lock recursion, in
> addition to overall looking particularly fragile to me. It seems to
> be handling the case where a page needs to be brought uptodate because
> a partial page write is being done. The page gets locked as many as 3
> times, each checking PageUptodate, however the two failure cases here
> go BUG() instead of returning an error.
yes, these are to be returned errors
> I'm starting to think that
> somehow the whole suspect branch just never gets taken, because
> otherwise I would expect to see bug reports related to -EIO, -ENOMEM,
> etc causing this to barf.
>
[snip]
>
> BOOM!!!
2.6.21-rc3-mm2 has this bug fixed.
> lock_page(page);
> if (!PageUptodate(page) && to_page != PAGE_CACHE_SIZE) {
>
> ---
>
> NATE
>
>
prev parent reply other threads:[~2007-03-15 17:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 5:40 [BUG] reiser4: page lock recursion in reiser4_write_extent Nate Diller
2007-03-14 16:30 ` Vladimir V. Saveliev
2007-03-15 17:34 ` Vladimir V. Saveliev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703152034.29962.vs@namesys.com \
--to=vs@namesys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nate.diller@gmail.com \
--cc=reiserfs-dev@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.