From: Theodore Tso <tytso@mit.edu>
To: "Brian D. Behlendorf" <behlendorf1@llnl.gov>
Cc: linux-ext4@vger.kernel.org, adilger@clusterfs.com, wartens2@llnl.gov
Subject: Re: e2fsprogs coverity patch <cid-03.diff>
Date: Sun, 18 Mar 2007 10:09:24 -0400 [thread overview]
Message-ID: <20070318140924.GC14519@thunk.org> (raw)
In-Reply-To: <200702100211.l1A2BQRE007265@igsi.llnl.gov>
On Fri, Feb 09, 2007 at 06:11:26PM -0800, Brian D. Behlendorf wrote:
> blkid_dev_has_tag() will immediately return -1 (an error if value is NULL. Thus
> at the test later on value cannot be NULL. There are two possible ways to go
> about fixing this. The first would be to remove the first NULL check for value.
> The second one would be to remove the second check (and the deadcode). I could
> be persuaded either way, but to preserve existing functionality I will opt to
> remove the second check.
Better to do this the other way, I think. It exposes more
functionality, and there shouldn't be any code that depends on
blkid_dev_has_tag returning an error is value is NULL.
- Ted
prev parent reply other threads:[~2007-03-18 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-10 2:11 e2fsprogs coverity patch <cid-3.diff> Brian D. Behlendorf
2007-03-18 14:09 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070318140924.GC14519@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@clusterfs.com \
--cc=behlendorf1@llnl.gov \
--cc=linux-ext4@vger.kernel.org \
--cc=wartens2@llnl.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.