From: Christoph Hellwig <hch@infradead.org>
To: Dmitriy Monakhov <dmonakhov@openvz.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ntfs-dev@lists.sourceforge.net, xfs@oss.sgi.com,
devel@openvz.org
Subject: Re: [PATCH 1/2] fs: remove duplicated iovec checking code v8
Date: Mon, 19 Mar 2007 09:28:28 +0000 [thread overview]
Message-ID: <20070319092828.GA3364@infradead.org> (raw)
In-Reply-To: <87slc18yhe.fsf@sw.ru>
On Mon, Mar 19, 2007 at 10:49:01AM +0300, Dmitriy Monakhov wrote:
>
> Where are several places where the same code used for iovec checks.
> This patch just move this code to separate helper function, and replace
> duplicated code with it. IMHO it is better because these are checks that
> we want for all filesystems/drivers that use vectored I/O.
Please move this into the common code path, so it's checked before
entering the filesystem. This won't cover the calculating count
until we have an iodesc/uio strcuture to pass it down, so feel free
to add a tiny helper for that temporaily.
prev parent reply other threads:[~2007-03-19 9:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 7:49 [PATCH 1/2] fs: remove duplicated iovec checking code v8 Dmitriy Monakhov
2007-03-19 7:49 ` Dmitriy Monakhov
2007-03-19 9:28 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070319092828.GA3364@infradead.org \
--to=hch@infradead.org \
--cc=devel@openvz.org \
--cc=dmonakhov@openvz.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.