From: Theodore Tso <tytso@mit.edu>
To: "Brian D. Behlendorf" <behlendorf1@llnl.gov>
Cc: linux-ext4@vger.kernel.org, adilger@clusterfs.com, wartens2@llnl.gov
Subject: Re: e2fsprogs coverity patch <cid-04.diff>
Date: Mon, 19 Mar 2007 08:32:34 -0400 [thread overview]
Message-ID: <20070319123234.GD14519@thunk.org> (raw)
In-Reply-To: <200702100211.l1A2BZvu007411@igsi.llnl.gov>
On Fri, Feb 09, 2007 at 06:11:35PM -0800, Brian D. Behlendorf wrote:
> This check is unnecessary since fs_type is guaranteed to be set earlier in the
> function.
>
> Coverity ID: 4: Deadcode
The code was actually supposed to be "dead", so in order to restore
the old behavior (from before support for /etc/mke2fs.conf was added)
I needed to move the setting of fs_type of "journal" earlier in the
function.
- Ted
prev parent reply other threads:[~2007-03-19 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-10 2:11 e2fsprogs coverity patch <cid-4.diff> Brian D. Behlendorf
2007-02-12 19:25 ` Andreas Dilger
2007-03-19 12:32 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070319123234.GD14519@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@clusterfs.com \
--cc=behlendorf1@llnl.gov \
--cc=linux-ext4@vger.kernel.org \
--cc=wartens2@llnl.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.