Re: [Qemu-devel] [PATCH] EABI fcntl on x86_64

["Kirill A. Shutemov" <k.shutemov@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

On [Mon, 19.03.2007 11:30], Stuart Anderson wrote:
> 
> When running ARM EABI binaries on x86_64, the target_eabi_flock64
> structure is already padded correct so the padding is not needed.
>
> This patch adds an #ifdef to only include the _pad member on 32-but
> hosts.

Are you sure that problem is in padding? Please, look at my patch 
in post "[PATCH] fcntl64 fix".
> 
> 
>                                 Stuart
> 
> Stuart R. Anderson                               anderson@netsweng.com
> Network & Software Engineering                   http://www.netsweng.com/
> 1024D/37A79149:                                  0791 D3B8 9A4C 2CDC A31F
>                                                  BD03 0A62 E534 37A7 9149

Content-Description: fcntl fix
> Index: linux-user/syscall_defs.h
> ===================================================================
> RCS file: /sources/qemu/qemu/linux-user/syscall_defs.h,v
> retrieving revision 1.30
> diff -u -r1.30 syscall_defs.h
> --- linux-user/syscall_defs.h	22 Oct 2006 00:18:54 -0000	1.30
> +++ linux-user/syscall_defs.h	19 Mar 2007 15:25:58 -0000
> @@ -1409,7 +1409,9 @@
>  struct target_eabi_flock64 {
>  	short  l_type;
>  	short  l_whence;
> +#if HOST_LONG_BITS == 32
>          int __pad;
> +#endif
>  	unsigned long long l_start;
>  	unsigned long long l_len;
>  	int  l_pid;

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]