From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernhard Walle Date: Mon, 19 Mar 2007 18:37:10 +0000 Subject: Re: [Fastboot] [PATCH] [REVIEW] Fix irqpoll on IA64 (timer interrupt != 0) Message-Id: <20070319183710.GA23499@strauss.suse.de> List-Id: References: <20070319181336.GC12628@strauss.suse.de> <9a8748490703191129h396211e9q59eeea9533d00c38@mail.gmail.com> In-Reply-To: <9a8748490703191129h396211e9q59eeea9533d00c38@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jesper Juhl Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, fastboot@lists.osdl.org * Jesper Juhl [2007-03-19 19:29]: > > > > -void > > +int > > register_percpu_irq (ia64_vector vec, struct irqaction *action) > > { > > Each and every function example in Documentation/CodingStyle has the > return type on the same line as the function name, so why not get > these in-line while you are modifying them anyway? Because all other functions in that file are coded this way. I think it looks better if you don't change the style in a particular file. Am I wrong? > int register_percpu_irq (ia64_vector vec, struct irqaction *action) > > > > @@ -174,6 +175,13 @@ void note_interrupt(unsigned int irq, st > > desc->irqs_unhandled = 0; > > } > > > > + > > +void set_timer_interrupt(unsigned int irq) > > Just one blank line between functions, as pr CodingStyle: > "In source files, separate functions with one blank line. ..." Fixed (locally). I'll repost if I get feedback of the contents of the patch. Regards, Bernhard From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030480AbXCSShO (ORCPT ); Mon, 19 Mar 2007 14:37:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030528AbXCSShO (ORCPT ); Mon, 19 Mar 2007 14:37:14 -0400 Received: from cantor.suse.de ([195.135.220.2]:42131 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030480AbXCSShL (ORCPT ); Mon, 19 Mar 2007 14:37:11 -0400 Date: Mon, 19 Mar 2007 19:37:10 +0100 From: Bernhard Walle To: Jesper Juhl Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, fastboot@lists.osdl.org Subject: Re: [Fastboot] [PATCH] [REVIEW] Fix irqpoll on IA64 (timer interrupt != 0) Message-ID: <20070319183710.GA23499@strauss.suse.de> Mail-Followup-To: Jesper Juhl , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, fastboot@lists.osdl.org References: <20070319181336.GC12628@strauss.suse.de> <9a8748490703191129h396211e9q59eeea9533d00c38@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9a8748490703191129h396211e9q59eeea9533d00c38@mail.gmail.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Jesper Juhl [2007-03-19 19:29]: > > > > -void > > +int > > register_percpu_irq (ia64_vector vec, struct irqaction *action) > > { > > Each and every function example in Documentation/CodingStyle has the > return type on the same line as the function name, so why not get > these in-line while you are modifying them anyway? Because all other functions in that file are coded this way. I think it looks better if you don't change the style in a particular file. Am I wrong? > int register_percpu_irq (ia64_vector vec, struct irqaction *action) > > > > @@ -174,6 +175,13 @@ void note_interrupt(unsigned int irq, st > > desc->irqs_unhandled = 0; > > } > > > > + > > +void set_timer_interrupt(unsigned int irq) > > Just one blank line between functions, as pr CodingStyle: > "In source files, separate functions with one blank line. ..." Fixed (locally). I'll repost if I get feedback of the contents of the patch. Regards, Bernhard