Re: [Qemu-devel] [PATCH] fcntl64 fix

["Kirill A. Shutemov" <k.shutemov@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1983 bytes --]

On [Tue, 20.03.2007 14:03], Stuart Anderson wrote:
> On Tue, 20 Mar 2007, Kirill A. Shutemov wrote:
> 
> >>What are you using as a test app?
> >
> >I got error when runing Debian's apt-get and tried to fix it.
> 
> OK, that's what got me started on this one, but I switched to using the
> ltp-kernel-test package for a more comprehensive set of tests once I got
> past that first eabi structure change.
> 
> >>I think that remapping the constants
> >>is needed, but I'm just curious how we seem to be coming up with different
> >>parts of the fix when we have the same target/host combination.
> >
> >I'm not sure that I understand you...
> 
> On the arm/x86_64 combination, I think the host & target cmd values are
> the same, so the remapping is a noop.

No. Remap is needed:

$ uname -m; echo -e '#include <fcntl.h>\nF_GETLK64' | cpp | tail -1
x86_64
5

$ uname -m; echo -e '#include <fcntl.h>\nF_GETLK64' | cpp | tail -1
armv5l
12

Same for F_SETLK64 and F_SETLKW64.

> It may be needed for other
> combinations though. Some architectures have very different values for
> constants like this in their ABI.
> 
> I was trying to understand how your fix made apt-get/dpkg happy, or if
> you were just using a different app that was hitting a different case
> for fcntl().
> 
> 
>                                 Stuart
> 
> Stuart R. Anderson                               anderson@netsweng.com
> Network & Software Engineering                   http://www.netsweng.com/
> 1024D/37A79149:                                  0791 D3B8 9A4C 2CDC A31F
>                                                  BD03 0A62 E534 37A7 9149
> 
> 
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
> 

-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + Velesys LLC, http://www.velesys.com/
 + ALT Linux Team, http://www.altlinux.com/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]