From: Christoph Hellwig <hch@infradead.org>
To: Mark Fasheh <mark.fasheh@oracle.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, hch@infradead.org,
viro@ftp.linux.org.uk
Subject: Re: [PATCH] Turn do_sync_file_range() into do_sync_mapping_range()
Date: Wed, 21 Mar 2007 14:44:26 +0000 [thread overview]
Message-ID: <20070321144426.GA25213@infradead.org> (raw)
In-Reply-To: <20070320214626.GC23274@ca-server1.us.oracle.com>
On Tue, Mar 20, 2007 at 02:46:26PM -0700, Mark Fasheh wrote:
> do_sync_file_range() accepts a file * from which it takes an address_space
> to sync. Abstract out the bulk of the function into do_sync_mapping_range()
> which takes the address_space directly. This way callers who want to sync an
> address_space directly can take advantage of the functionality provided.
>
> do_sync_file_range() is preserved as a 3 line wrapper around
> do_sync_mapping_range().
>
> Ocfs2 in particular would like to use this to initiate a sync of a specific
> inode range during truncate, where a file * may not be available.
Looks good to me, but I agree with Andrew that we should simply
kill do_sync_file_range, espcially as at least one of the callers
has file->f_mapping guaranteed != NULL;
next prev parent reply other threads:[~2007-03-21 14:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 21:46 [PATCH] Turn do_sync_file_range() into do_sync_mapping_range() Mark Fasheh
2007-03-21 6:30 ` Andrew Morton
2007-03-21 14:44 ` Christoph Hellwig [this message]
2007-03-21 16:12 ` Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321144426.GA25213@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.fasheh@oracle.com \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.