From: Jean Delvare <khali@linux-fr.org>
To: Marc St-Jean <Marc_St-Jean@pmc-sierra.com>
Cc: linux-mips@linux-mips.org, i2c@lm-sensors.org
Subject: Re: [PATCH 8/12] drivers: PMC MSP71xx TWI driver]
Date: Wed, 21 Mar 2007 16:34:26 +0100 [thread overview]
Message-ID: <20070321163426.0a442deb.khali@linux-fr.org> (raw)
In-Reply-To: <46007F7F.9030604@pmc-sierra.com>
Hi Marc,
On Tue, 20 Mar 2007 16:42:39 -0800, Marc St-Jean wrote:
> Jean Delvare wrote:
> > Why are you making a separate algorithm driver? This should really only
> > be done when the algorithm is very generic. This is the exception, not
> > the rule. These days I tend to move algorithm code back into the only
> > bus driver that uses them (i2c-algo-sibyte done recently, i2c-algo-sgi
> > is next on my list.)
>
> I believe it was done to separate the algorithm for the TWI sub-system,
> which is used in several devices, from the device family code. If this
> is no longer acceptable I will merge the algo code with the adapter.
You should be able to have a single i2c bus driver handling all the
different devices, by using the platform data to provide the
device-specific configuration. The i2c-algorithm concept is quite old,
now that we have a clean new device driver model it should no longer be
necessary in most cases.
--
Jean Delvare
next prev parent reply other threads:[~2007-03-21 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 0:42 [PATCH 8/12] drivers: PMC MSP71xx TWI driver] Marc St-Jean
2007-03-21 15:34 ` Jean Delvare [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-03-16 23:03 Ralf Baechle
2007-03-17 7:52 ` Jean Delvare
2007-03-19 10:41 ` Ladislav Michl
2007-03-19 13:36 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321163426.0a442deb.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=Marc_St-Jean@pmc-sierra.com \
--cc=i2c@lm-sensors.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.