From: "Jörn Engel" <joern@lazybastard.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Jarek Poplawski <jarkao2@o2.pl>,
Eric Dumazet <dada1@cosmosbay.com>,
mpm@selenic.com, Christoph Lameter <clameter@sgi.com>,
"ast@domdv.de" <ast@domdv.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] slab: deal with NULL pointers passed to kmem_cache_free
Date: Wed, 21 Mar 2007 18:54:13 +0100 [thread overview]
Message-ID: <20070321175413.GC455@lazybastard.org> (raw)
In-Reply-To: <20070321083027.437361f1.akpm@linux-foundation.org>
On Wed, 21 March 2007 08:30:27 -0800, Andrew Morton wrote:
> On Wed, 21 Mar 2007 16:41:19 +0200 "Pekka Enberg" <penberg@cs.helsinki.fi> wrote:
>
> > Yeah, I'll try to sneak a patch past Andrew.
>
> That would be sneaky.
>
> Thing is, such a patch would amount to adding a test-for-NULL to codepaths
> which we *know* do not need it. There is no point in doing that.
How about two patches, one renaming kmem_cache_free to
kmem_cache_free_fast or __kmem_cache_free or whatever pleases you most,
the second adding kmem_cache_free with a NULL check.
The point is that the easiest way to use kmem_cache_free should be the
safest, but not necessarily the fastest. Existing well-tuned and
NULL-aware code paths can remain fast, random new code will be safe.
Jörn
--
Joern's library part 14:
http://www.sandpile.org/
next prev parent reply other threads:[~2007-03-21 18:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 8:27 [PATCH] slab: deal with NULL pointers passed to kmem_cache_free Pekka J Enberg
2007-03-19 11:31 ` Andrew Morton
2007-03-19 11:40 ` Pekka J Enberg
2007-03-19 17:08 ` Christoph Lameter
2007-03-19 17:31 ` Pekka J Enberg
2007-03-19 20:49 ` Matt Mackall
2007-03-19 21:10 ` Andrew Morton
2007-03-19 21:25 ` Pekka Enberg
2007-03-19 21:41 ` Andrew Morton
2007-03-19 21:49 ` Matt Mackall
2007-03-20 7:06 ` Pekka Enberg
2007-03-20 18:41 ` Christoph Lameter
2007-03-21 11:42 ` Pekka J Enberg
2007-03-20 7:14 ` Pekka Enberg
2007-03-20 7:39 ` Eric Dumazet
2007-03-20 7:47 ` Pekka J Enberg
2007-03-20 7:56 ` Eric Dumazet
2007-03-21 10:11 ` Jarek Poplawski
2007-03-21 12:13 ` Pekka Enberg
2007-03-21 13:31 ` Jarek Poplawski
2007-03-21 13:36 ` Pekka J Enberg
2007-03-21 14:11 ` Rafael J. Wysocki
2007-03-21 14:41 ` Pekka Enberg
2007-03-21 16:30 ` Andrew Morton
2007-03-21 17:54 ` Jörn Engel [this message]
2007-03-21 18:32 ` Pekka Enberg
2007-03-21 14:45 ` Jarek Poplawski
2007-03-19 22:04 ` Jörn Engel
2007-03-19 21:16 ` Christoph Lameter
2007-03-19 21:44 ` Matt Mackall
2007-03-19 23:32 ` Andreas Steinmetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321175413.GC455@lazybastard.org \
--to=joern@lazybastard.org \
--cc=akpm@linux-foundation.org \
--cc=ast@domdv.de \
--cc=clameter@sgi.com \
--cc=dada1@cosmosbay.com \
--cc=jarkao2@o2.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.