From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] SUCCESS! Re: MSI K9N4 SLI-F sensors-detect says
Date: Wed, 21 Mar 2007 17:09:44 +0000 [thread overview]
Message-ID: <20070321180944.63cd0a38.khali@linux-fr.org> (raw)
In-Reply-To: <4600D064.1020703@curtronics.com>
Hi Curt,
On Wed, 21 Mar 2007 01:27:48 -0500, Curt Blank wrote:
> Ok, I answered my own question, yes I can backport the w83627ehf driver
> from 2.6.21 to 2.6.16.
>
> If anyone is interested I put the patches here:
>
> http://www.curtronics.com/patches/
>
> Not bad for one nights work.
>
> Below is the living proof. The chip ID reported by the W83627DHG on this
> MB was different then what the 2.6.21 w83627ehf code looked for so now
> it looks for both. There are 4 fans connected to this MB but only 3 are
> showing up, the 4th is a MSI installed fan on the Northbridge chip.
> Maybe I can't see that one, I don't know at this point. I have to
> validate the voltages also, they don't look quite right.
Two comments about this patch:
1* You didn't have to convert the semaphores to mutexes. This is a
kernel-wide change that happened at one point in time, and is not
related with the W83627DHG support at all. Without that change, your
patch will be smaller.
2* You do not need to change the device ID. If you look at the code,
you'll see that we do explicitely mask out the lower bits, because they
are _known_ to change depending on the exact chip revision. So the
original code should work just fine for you too.
--
Jean Delvare
next prev parent reply other threads:[~2007-03-21 17:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 6:27 [lm-sensors] SUCCESS! Re: MSI K9N4 SLI-F sensors-detect says use Curt Blank
2007-03-21 16:55 ` [lm-sensors] SUCCESS! Re: MSI K9N4 SLI-F sensors-detect says David Hubbard
2007-03-21 17:09 ` Jean Delvare [this message]
2007-03-21 17:15 ` Curt Blank
2007-03-21 17:36 ` Curt Blank
2007-03-21 17:39 ` David Hubbard
2007-03-21 17:42 ` Curt Blank
2007-03-21 17:52 ` Curt Blank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321180944.63cd0a38.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.