From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from caramon.arm.linux.org.uk ([217.147.92.249]:4359 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965268AbXCUWR6 (ORCPT ); Wed, 21 Mar 2007 18:17:58 -0400 Date: Wed, 21 Mar 2007 22:17:48 +0000 From: Russell King Subject: Re: + move-die-notifier-handling-to-common-code.patch added to -mm tree Message-ID: <20070321221748.GD28239@flint.arm.linux.org.uk> References: <200703212211.l2LMB08x005006@shell0.pdx.osdl.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200703212211.l2LMB08x005006@shell0.pdx.osdl.net> Sender: linux-arch-owner@vger.kernel.org To: akpm@linux-foundation.org Cc: mm-commits@vger.kernel.org, hch@lst.de, linux-arch@vger.kernel.org List-ID: On Wed, Mar 21, 2007 at 03:11:00PM -0700, akpm@linux-foundation.org wrote: > ------------------------------------------------------ > Subject: move die notifier handling to common code > From: Christoph Hellwig > > This patch moves the die notifier handling to common code. Previous > various architectures had exactly the same code for it. Note that the new > code is compiled unconditionally, this should be understood as an appel to > the other architecture maintainer to implement support for it aswell (aka > sprinkling a notify_die or two in the proper place) > > arm had a notifiy_die that did something totally different, I renamed it to > arm_notify_die as part of the patch and made it static to the file it's > declared and used at. avr32 used to pass slightly less information through > this interface and I brought it into line with the other architectures. > > Signed-off-by: Christoph Hellwig > Cc: > Signed-off-by: Andrew Morton NAK. This will, as seems to be the current favourite past time, break ARM. A simple grep command will show why; I leave it as an exercise for those to run this command to discover the details. $ grep notify_die arch/arm -r -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: