From: Maxim <maximlevitsky@gmail.com>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jan Engelhardt <jengelh@linux01.gwdg.de>, Andi Kleen <ak@suse.de>,
David Howells <dhowells@redhat.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] : Is /proc/kcore still usefull and/or maintained ?
Date: Thu, 22 Mar 2007 02:04:50 +0200 [thread overview]
Message-ID: <200703220204.51146.maximlevitsky@gmail.com> (raw)
In-Reply-To: <20070322005310.03be8637.dada1@cosmosbay.com>
On Thursday 22 March 2007 01:53:10 Eric Dumazet wrote:
> I stand corrected : This is a new bug
>
> The /proc/kcore problem appears with linux-2.6.21-rc4-mm1
>
> fd = open("/proc/kcore", 0);
> llseek(fd, ...) returns an -EINVAL error
>
>
> Quick code inspection (before going to sleep...) shows that
>
> proc_reg_llseek() (file fs/proc/inode.c)
>
> is doing something like :
>
> rv = -EINVAL;
> llseek = pde->proc_fops->llseek;
> spin_unlock(&pde->pde_unload_lock);
> if (llseek)
> rv = llseek(file, offset, whence);
>
> As kcore dont have a .llseek handler, proc_reg_llseek() returns -EINVAL;
>
> Previous kernel was probably calling a default llseek() handler.
>
> if (!llseek)
> llseek = default_llseek;
>
> Hum ???
>
Hi,
Yes, you are right, you have different problem that I had
But why do you need llseek ?
Why not to mmap it ?
It is natural thing to do with files that represent memory.
Regards,
Maxim Levitsky
next prev parent reply other threads:[~2007-03-22 0:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 16:40 [BUG] Code reordering in swsusp breaks suspend on SMP systems Maxim Levitsky
2007-03-21 21:22 ` Nigel Cunningham
2007-03-21 21:38 ` Rafael J. Wysocki
2007-03-21 23:47 ` Nigel Cunningham
2007-03-22 0:25 ` Maxim
2007-03-22 4:51 ` David Chinner
2007-03-22 7:23 ` Rafael J. Wysocki
2007-03-22 7:31 ` Andrew Morton
2007-03-22 8:17 ` Rafael J. Wysocki
[not found] ` <200703220114.05228.maximlevitsky@gmail.com>
2007-03-21 23:16 ` Maxim
2007-03-22 0:32 ` Maxim
2007-03-21 22:21 ` Pavel Machek
2007-03-21 22:39 ` Rafael J. Wysocki
2007-03-21 22:58 ` [RFC] : Is /proc/kcore still usefull and/or maintained ? Eric Dumazet
2007-03-21 23:11 ` Jan Engelhardt
2007-03-21 23:28 ` Maxim
2007-03-21 23:53 ` Eric Dumazet
2007-03-22 0:04 ` Maxim [this message]
2007-03-22 6:35 ` Eric Dumazet
[not found] ` <200703220109.54719.maximlevitsky@gmail.com>
2007-03-21 23:18 ` [BUG] Code reordering in swsusp breaks suspend on SMP systems Maxim
[not found] ` <200703220024.25436.rjw@sisk.pl>
2007-03-21 23:39 ` Maxim
2007-03-21 23:44 ` Maxim
2007-03-21 23:53 ` Rafael J. Wysocki
2007-03-22 0:01 ` Maxim
2007-03-22 23:30 ` Rafael J. Wysocki
2007-03-23 14:42 ` Rafael J. Wysocki
2007-03-25 0:40 ` Maxim
2007-03-25 12:13 ` Rafael J. Wysocki
2007-03-25 15:10 ` Maxim
2007-03-25 19:27 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703220204.51146.maximlevitsky@gmail.com \
--to=maximlevitsky@gmail.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dada1@cosmosbay.com \
--cc=dhowells@redhat.com \
--cc=jengelh@linux01.gwdg.de \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.