diff for duplicates of <200703221137.35906.dtor@insightbb.com> diff --git a/a/1.txt b/N1/1.txt index e842132..89f7dcd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,28 +1,28 @@ Hi Nicolas, On Monday 19 March 2007 01:19, Nicolas Boichat wrote: -> +???????/* initialize the input class */ -> +???????applesmc_idev->name = "applesmc"; +> + /* initialize the input class */ +> + applesmc_idev->name = "applesmc"; You may want to set applesmc_idev->id.bus = BUS_HOST; -> +???????applesmc_idev->cdev.dev = &pdev->dev; -> +???????applesmc_idev->evbit[0] = BIT(EV_ABS); -> +???????input_set_abs_params(applesmc_idev, ABS_X, -> +???????????????????????-256, 256, APPLESMC_INPUT_FUZZ, APPLESMC_INPUT_FLAT); -> +???????input_set_abs_params(applesmc_idev, ABS_Y, -> +???????????????????????-256, 256, APPLESMC_INPUT_FUZZ, APPLESMC_INPUT_FLAT); +> + applesmc_idev->cdev.dev = &pdev->dev; +> + applesmc_idev->evbit[0] = BIT(EV_ABS); +> + input_set_abs_params(applesmc_idev, ABS_X, +> + -256, 256, APPLESMC_INPUT_FUZZ, APPLESMC_INPUT_FLAT); +> + input_set_abs_params(applesmc_idev, ABS_Y, +> + -256, 256, APPLESMC_INPUT_FUZZ, APPLESMC_INPUT_FLAT); > + -> +???????input_register_device(applesmc_idev); +> + input_register_device(applesmc_idev); Please add error hanling here. > + -> +???????/* start up our timer for the input device */ -> +???????init_timer(&applesmc_timer); -> +???????applesmc_timer.function = applesmc_mousedev_poll; -> +???????applesmc_timer.expires = jiffies + APPLESMC_POLL_PERIOD; -> +???????add_timer(&applesmc_timer); +> + /* start up our timer for the input device */ +> + init_timer(&applesmc_timer); +> + applesmc_timer.function = applesmc_mousedev_poll; +> + applesmc_timer.expires = jiffies + APPLESMC_POLL_PERIOD; +> + add_timer(&applesmc_timer); > Please consider implemention open and close methods for the input diff --git a/a/content_digest b/N1/content_digest index 8b74e0e..2bcade3 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\045F7C083.7090504@boichat.ch\0" "ref\045FE1D44.8000805@boichat.ch\0" - "From\0dtor@insightbb.com (Dmitry Torokhov)\0" - "Subject\0[lm-sensors] [PATCH] Apple SMC driver (hardware monitoring and\0" - "Date\0Thu, 22 Mar 2007 15:37:34 +0000\0" + "From\0Dmitry Torokhov <dtor@insightbb.com>\0" + "Subject\0Re: [PATCH] Apple SMC driver (hardware monitoring and control)\0" + "Date\0Thu, 22 Mar 2007 11:37:34 -0400\0" "To\0Nicolas Boichat <nicolas@boichat.ch>\0" "Cc\0Andrew Morton <akpm@linux-foundation.org>" linux-kernel@vger.kernel.org @@ -14,28 +14,28 @@ "Hi Nicolas,\n" "\n" "On Monday 19 March 2007 01:19, Nicolas Boichat wrote:\n" - "> +???????/* initialize the input class */\n" - "> +???????applesmc_idev->name = \"applesmc\";\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240/* initialize the input class */\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240applesmc_idev->name = \"applesmc\";\n" "\n" "You may want to set applesmc_idev->id.bus = BUS_HOST;\n" "\n" - "> +???????applesmc_idev->cdev.dev = &pdev->dev;\n" - "> +???????applesmc_idev->evbit[0] = BIT(EV_ABS);\n" - "> +???????input_set_abs_params(applesmc_idev, ABS_X,\n" - "> +???????????????????????-256, 256, APPLESMC_INPUT_FUZZ, APPLESMC_INPUT_FLAT);\n" - "> +???????input_set_abs_params(applesmc_idev, ABS_Y,\n" - "> +???????????????????????-256, 256, APPLESMC_INPUT_FUZZ, APPLESMC_INPUT_FLAT);\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240applesmc_idev->cdev.dev = &pdev->dev;\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240applesmc_idev->evbit[0] = BIT(EV_ABS);\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240input_set_abs_params(applesmc_idev, ABS_X,\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240-256, 256, APPLESMC_INPUT_FUZZ, APPLESMC_INPUT_FLAT);\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240input_set_abs_params(applesmc_idev, ABS_Y,\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240-256, 256, APPLESMC_INPUT_FUZZ, APPLESMC_INPUT_FLAT);\n" "> +\n" - "> +???????input_register_device(applesmc_idev);\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240input_register_device(applesmc_idev);\n" "\n" "Please add error hanling here.\n" "\n" "> +\n" - "> +???????/* start up our timer for the input device */\n" - "> +???????init_timer(&applesmc_timer);\n" - "> +???????applesmc_timer.function = applesmc_mousedev_poll;\n" - "> +???????applesmc_timer.expires = jiffies + APPLESMC_POLL_PERIOD;\n" - "> +???????add_timer(&applesmc_timer);\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240/* start up our timer for the input device */\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240init_timer(&applesmc_timer);\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240applesmc_timer.function = applesmc_mousedev_poll;\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240applesmc_timer.expires = jiffies + APPLESMC_POLL_PERIOD;\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240add_timer(&applesmc_timer);\n" "> \n" "\n" "Please consider implemention open and close methods for the input\n" @@ -45,4 +45,4 @@ "-- \n" Dmitry -29a2242e17b7f6dc363e3f311fe571951822cb72bdaf3dc2c70488d77f10e007 +de9d47ca8d0da417ce62488c55df687c699c6d62c2d0cbf30f1b9486b1b66268
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.