From: Paul Mundt <lethal@linux-sh.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-pm@lists.linux-foundation.org,
Johannes Berg <johannes@sipsolutions.net>,
Andrew Morton <akpm@linux-foundation.org>,
Russell King <rmk@arm.linux.org.uk>
Subject: Re: + rework-pm_ops-pm_disk_mode-kill-misuse.patch added to -mm tree
Date: Thu, 22 Mar 2007 23:35:56 +0900 [thread overview]
Message-ID: <20070322143556.GA22798@linux-sh.org> (raw)
In-Reply-To: <20070322143313.GA7963@elf.ucw.cz>
On Thu, Mar 22, 2007 at 03:33:13PM +0100, Pavel Machek wrote:
> On Thu 2007-03-22 23:24:37, Paul Mundt wrote:
> > On Thu, Mar 22, 2007 at 02:31:17PM +0100, Pavel Machek wrote:
> > > Hohum, perhaps it can suspend to SD card? Or perhaps it can suspend
> > > over network?
> > >
> > > Suspend code will properly fail if there's not enough swap space.
> > >
> > > ...plus you are allowed to return -EINVAL from arch_prepare_suspend()
> > > or how is it called.
> >
> > So then how exactly is this helping anything? It's pointless to have the
> > sysfs file visible for platforms that are never going to support suspend
> > to disk, and -EINVAL'ing out in another path is simply moving the
> > problem.
>
> Platforms that are never going to support s2disk
>
> a) should be fixed
>
> b) do not have CONFIG_SOFTWARE_SUSPEND.
Ah, that's the part I was missing. Ok, As long as the memory-only thing
is explicit, then I don't see any problem with these.
Acked-by: Paul Mundt <lethal@linux-sh.org>
next prev parent reply other threads:[~2007-03-22 14:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 23:34 + rework-pm_ops-pm_disk_mode-kill-misuse.patch added to -mm tree akpm
2007-03-22 9:48 ` Russell King
2007-03-22 9:56 ` Andrew Morton
2007-03-22 10:03 ` Pavel Machek
2007-03-22 10:08 ` Johannes Berg
2007-03-22 13:26 ` Russell King
2007-03-22 13:31 ` Pavel Machek
2007-03-22 13:41 ` Vitaly Wool
2007-03-22 14:03 ` Pavel Machek
2007-03-22 14:27 ` Vitaly Wool
2007-03-22 14:33 ` Pavel Machek
2007-03-22 15:23 ` Johannes Berg
2007-03-22 15:26 ` Vitaly Wool
2007-03-22 14:24 ` Paul Mundt
2007-03-22 14:33 ` Pavel Machek
2007-03-22 14:35 ` Paul Mundt [this message]
2007-03-22 17:36 ` Andrew Morton
2007-03-22 17:51 ` Johannes Berg
2007-03-22 15:05 ` Johannes Berg
2007-03-22 15:23 ` Vitaly Wool
2007-03-22 15:28 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2007-03-21 23:34 akpm
2007-03-22 18:00 akpm
2007-03-22 18:00 akpm
2007-04-27 22:11 ` Johannes Berg
2007-04-27 22:55 ` Andrew Morton
2007-04-28 6:40 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070322143556.GA22798@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.