All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: Christoph Hellwig <hch@infradead.org>,
	linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: request_queue_t depends on CONFIG_BLOCK
Date: Fri, 23 Mar 2007 01:10:02 +0100	[thread overview]
Message-ID: <20070323001002.GA14583@aepfle.de> (raw)
In-Reply-To: <20070322215351.GA7216@infradead.org>

On Thu, Mar 22, Christoph Hellwig wrote:

> On Thu, Mar 22, 2007 at 10:52:34PM +0100, Olaf Hering wrote:
> > How can this compile error be fixed properly?
> > request_queue_t is inside CONFIG_BLOCK,
> > ide_drive_s (and likely others) use it unconditionally.
> > 
> > 
> >   CC      arch/powerpc/kernel/setup_64.o
> > In file included from linux-2.6.21-rc4/arch/powerpc/kernel/setup_64.c:23:
> 
> start looking for the problem here.  Why does you arch code include ide.h?

Because it is needed in a few places.
Better hide everything in ide.h inside #ifdef CONFIG_IDE

  reply	other threads:[~2007-03-23  0:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-22 21:52 request_queue_t depends on CONFIG_BLOCK Olaf Hering
2007-03-22 21:53 ` Christoph Hellwig
2007-03-23  0:10   ` Olaf Hering [this message]
2007-03-23 18:29     ` Bartlomiej Zolnierkiewicz
2007-03-23 19:14       ` Olaf Hering
2007-03-23 20:29         ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070323001002.GA14583@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=hch@infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.