From: David Gibson <david@gibson.dropbear.id.au>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Remove bogus errors from check_chosen.
Date: Fri, 23 Mar 2007 14:31:58 +1100 [thread overview]
Message-ID: <20070323033158.GG28006@localhost.localdomain> (raw)
In-Reply-To: <20070322161109.GA20512@ld0162-tx32.am.freescale.net>
On Thu, Mar 22, 2007 at 11:11:09AM -0500, Scott Wood wrote:
> It is not an error for /chosen (or any of its children) to be missing.
>
> It is not a requirement that the output of dtc be a complete, valid
> device tree, as it may be intended that the dtb be passed through boot
> code that will complete it. Thus, do not complain.
I'm not 100% comfortable with this patch; I'd like for dtc to have the
facility to do more-or-less complete tree validation. However, as you
point out it's really irritating right now, so I think removing the
check is the best approach for now. If I ever get around to
implementing a decent error/warning handling framework for dtc, then
more complete checking can go back in under the right circumstances.
> Signed-off-by: Scott Wood <scottwood@freescale.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-03-23 3:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-22 16:11 [PATCH] Remove bogus errors from check_chosen Scott Wood
2007-03-22 16:22 ` Scott Wood
2007-03-23 3:31 ` David Gibson [this message]
2007-03-23 15:05 ` Scott Wood
2007-03-23 15:21 ` Jerry Van Baren
2007-03-23 15:36 ` Scott Wood
2007-03-23 15:48 ` Jerry Van Baren
2007-03-23 23:42 ` David Gibson
2007-03-23 23:40 ` David Gibson
2007-03-23 16:03 ` Jon Loeliger
2007-03-23 23:51 ` David Gibson
2007-03-26 13:35 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070323033158.GG28006@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.