Re: [patch] [bugfix] loop.c

[William Lee Irwin III <wli@holomorphy.com>]

On Fri, 23 Mar 2007 15:04:54 +0100 Tomas M <tomas@slax.org> wrote:
>> I posted this yesterday but it seems people didn't understand the real 
>> goal of my patch. So I will explain once more again:
>> This is a bugfix for loop.c block driver, as it currently allocates more 
>> memory then it needs, without any further use.

On Fri, Mar 23, 2007 at 03:19:56PM +0100, Eric Dumazet wrote:
> Well... changing the Changelog wont help I'm afraid.
> I cooked the following patch (untested), feel free to test it.

The array of preallocated garbage is to be killed by instantiating the
driver-private state at ->open() or at the time of file attachment or
whatever (I myself am not entirely sure of the right way to go about it).
I think someone's working on writing a patch of that form. I'm not sure
what they say is to be done about the gendisk array but I think there
are other ways to find the things by major and minor numbers.

IOW teaching loop.c to allocate more is not the way to go; one should
rather teach it to avoid doing all those allocations up-front.


-- wli