All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] have merge put FETCH_HEAD data in commit message
Date: Fri, 23 Mar 2007 11:33:14 -0400	[thread overview]
Message-ID: <20070323153314.GA2364@fieldses.org> (raw)
In-Reply-To: <200703231523.58150.jnareb@gmail.com>

On Fri, Mar 23, 2007 at 03:23:55PM +0100, Jakub Narebski wrote:
> J. Bruce Fields wrote:
> > On Fri, Mar 23, 2007 at 02:57:38PM +0100, Jakub Narebski wrote:
> >> Junio C Hamano wrote:
> >> 
> >>> +The commit message is formed by the title taken from the
> >>> +"Subject: ", a blank line and the body of the message up to
> >>> +where the patch begins.  Excess whitespaces at the end of the
> >>> +lines are automatically stripped.
> >> 
> >> Does this mean that git-am cannot make a log message that doesn't
> >> follow git formatting commit message guidelines, namely short one-line
> >> description, then longer description and signoff?

Oh, sorry, I see--I misread "make" for "take" in the above!

> > 
> > The input to git-am is email, not log messages.
> 
> But that means that commit message which doesn't have empty line after
> first line cannot be send via git-send-email + git-am without changes,
> not be subject to git-rebase (which uses git-am machinery unless invoked
> with --merge option) without changing commit message, isn't it?

Yup.

Doesn't seem like a big deal to me.  But then it'd also seem more
sensible to me if git-rebase worked directly with the original commits
rather than going through git-format-patch/git-am.  Maybe what I want is
a git-cherry-pick that will accept a range.

--b.

  reply	other threads:[~2007-03-23 15:33 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-21 12:06 [PATCH] have merge put FETCH_HEAD data in commit message Michael S. Tsirkin
2007-03-21 15:37 ` Junio C Hamano
2007-03-22  5:02   ` Michael S. Tsirkin
2007-03-22  5:09     ` Junio C Hamano
2007-03-22  6:28       ` Michael S. Tsirkin
2007-03-22  7:15         ` Junio C Hamano
2007-03-22  7:41           ` Michael S. Tsirkin
2007-03-22  8:21             ` Junio C Hamano
2007-03-22  8:37               ` Michael S. Tsirkin
2007-03-22 10:31                 ` Junio C Hamano
2007-03-22 10:40                   ` Michael S. Tsirkin
2007-03-24 10:21                     ` Junio C Hamano
2007-04-04  6:02                       ` Michael S. Tsirkin
2007-04-04  6:09                         ` Junio C Hamano
2007-04-04  6:18                           ` Michael S. Tsirkin
2007-04-04  6:19                           ` Shawn O. Pearce
2007-04-04  6:25                             ` Junio C Hamano
2007-04-04  6:35                               ` Shawn O. Pearce
2007-04-04  6:24                         ` Junio C Hamano
2007-04-04  7:01                           ` [PATCH] display shortlog after git-commit Michael S. Tsirkin
2007-04-04  7:22                             ` Junio C Hamano
2007-04-15 22:39                               ` Michael S. Tsirkin
2007-04-15 23:08                                 ` Junio C Hamano
2007-04-16  3:53                                   ` [PATCH] display the subject of the commit just made Michael S. Tsirkin
2007-04-16  5:16                                     ` Junio C Hamano
2007-04-16  5:40                                       ` Michael S. Tsirkin
2007-04-16  6:17                                         ` Junio C Hamano
2007-04-16  5:51                                       ` Michael S. Tsirkin
2007-04-16  6:01                                         ` Junio C Hamano
2007-04-16  6:18                                           ` Michael S. Tsirkin
2007-04-16  6:51                                             ` Michael S. Tsirkin
2007-04-16  7:00                                               ` Junio C Hamano
2007-04-16  7:11                                                 ` Shawn O. Pearce
2007-04-16  7:59                                                   ` Michael S. Tsirkin
2007-04-16 12:56                                                   ` Alex Riesen
2007-04-16 17:46                                                     ` Junio C Hamano
2007-04-16  5:34                                   ` [PATCH] display shortlog after git-commit Michael S. Tsirkin
2007-04-16  6:04                                     ` Junio C Hamano
2007-04-16  6:26                                       ` Michael S. Tsirkin
2007-04-16 14:40                                       ` [PATCH] remove shortlog from git-commit output Michael S. Tsirkin
2007-04-16 15:02                                         ` Julian Phillips
2007-04-16 18:23                                           ` Michael S. Tsirkin
2007-04-16 20:21                                             ` Julian Phillips
2007-04-17  6:02                                               ` Michael S. Tsirkin
2007-04-17  7:27                                                 ` Julian Phillips
2007-04-04  8:15                             ` [PATCH] display shortlog after git-commit Junio C Hamano
2007-04-15 10:33                               ` Michael S. Tsirkin
2007-04-15 19:57                                 ` Junio C Hamano
2007-04-15 20:09                                   ` Michael S. Tsirkin
2007-04-15 20:26                                     ` Andy Parkins
2007-04-15 20:34                                       ` Michael S. Tsirkin
2007-04-04  6:24                         ` [PATCH] wt-status: show author info if status.showauthor is set Jeff King
2007-04-04  6:32                           ` Junio C Hamano
2007-04-04  6:49                           ` Michael S. Tsirkin
2007-04-04  6:52                             ` Junio C Hamano
2007-04-04  6:55                             ` Shawn O. Pearce
2007-04-04 13:28                           ` Jakub Narebski
2007-03-23 13:57                   ` [PATCH] have merge put FETCH_HEAD data in commit message Jakub Narebski
2007-03-23 13:59                     ` J. Bruce Fields
2007-03-23 14:23                       ` Jakub Narebski
2007-03-23 15:33                         ` J. Bruce Fields [this message]
2007-03-24  0:03                           ` Jakub Narebski
2007-03-22  9:07               ` [PATCH] Put FETCH_HEAD data in merge " Michael S. Tsirkin
2007-03-22 10:01                 ` Junio C Hamano
2007-03-22  8:33   ` [PATCH] have merge put FETCH_HEAD data in " Jeff King
2007-03-22  8:51     ` Junio C Hamano
2007-03-22  9:09       ` Jeff King
2007-03-22  9:10   ` Andy Parkins
2007-03-21 17:29 ` [PATCHv2] put FETCH_HEAD data in merge " Michael S. Tsirkin
2007-03-21 18:09   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070323153314.GA2364@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.