From: "Frank Ch. Eigler" <fche@redhat.com>
To: "Stone, Joshua I" <joshua.i.stone@intel.com>
Cc: "Keshavamurthy, Anil S" <anil.s.keshavamurthy@intel.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Prasanna S Panchamukhi <prasanna@in.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
SystemTAP <systemtap@sources.redhat.com>,
Satoshi Oshima <soshima@redhat.com>,
Hideo Aoki <haoki@redhat.com>,
Yumiko Sugita <yumiko.sugita.yf@hitachi.com>,
"Frank Ch. Eigler" <fche@redhat.com>,
hch@infradead.org
Subject: Re: [RFC][Patch 1/4] kprobe fast unregistration
Date: Fri, 23 Mar 2007 14:22:48 -0400 [thread overview]
Message-ID: <20070323182248.GA32364@redhat.com> (raw)
In-Reply-To: <16D5B9AB904B0B46B22A27002EE3A8C82793BB@scsmsx415.amr.corp.intel.com>
Hi -
Keshavamurthy, Anil S wrote:
> I agree with Christoph that the interface is horrible and error prone.
Really? What possible problems can occur? The worst that occurs to
me is that if someone forgets to call the commit function, the kprobes
will still be disabled, but memory won't be recycled for a while. Is
this really so bad, considering that a kprobe_unregister is to imply a
commit? Maybe if kprobe_register can also implied a commit, we can
bound the conceivable memory leak.
Would it be possible to allay even that concern with an automated
deferred/periodic commit?
- FChE
next prev parent reply other threads:[~2007-03-23 18:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 14:43 [RFC][Patch 1/4] kprobe fast unregistration Masami Hiramatsu
2007-03-23 14:45 ` [RFC][Patch 2/4] kretprobe fast unregisteration Masami Hiramatsu
2007-03-23 14:46 ` [RFC][Patch 3/4] jprobe " Masami Hiramatsu
2007-03-23 14:47 ` [RFC][Patch 4/4] kprobes fast unregisteration documentation Masami Hiramatsu
2007-03-23 17:23 ` [RFC][Patch 1/4] kprobe fast unregistration Christoph Hellwig
[not found] ` <20070323180527.GA13728@bambi.jf.intel.com>
2007-03-23 18:12 ` Stone, Joshua I
2007-03-23 18:22 ` Frank Ch. Eigler [this message]
[not found] ` <20070323190127.GA13974@bambi.jf.intel.com>
2007-03-26 2:29 ` Frank Ch. Eigler
2007-03-31 13:01 ` Christoph Hellwig
2007-03-31 13:06 ` Christoph Hellwig
2007-03-26 3:17 ` Masami Hiramatsu
[not found] ` <20070326181518.GA28384@bambi.jf.intel.com>
2007-03-27 3:24 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070323182248.GA32364@redhat.com \
--to=fche@redhat.com \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=haoki@redhat.com \
--cc=hch@infradead.org \
--cc=joshua.i.stone@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=prasanna@in.ibm.com \
--cc=soshima@redhat.com \
--cc=systemtap@sources.redhat.com \
--cc=yumiko.sugita.yf@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.