From: Michael Buesch <mb@bu3sch.de>
To: Stefano Brivio <stefano.brivio@polimi.it>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, bcm43xx-dev@lists.berlios.de
Subject: Re: [PATCH] bcm43xx-mac80211: fix radio_set_tx_iq
Date: Fri, 23 Mar 2007 21:25:59 +0100 [thread overview]
Message-ID: <200703232125.59781.mb@bu3sch.de> (raw)
In-Reply-To: <20070323202343.0e7ea0e7@localhost>
On Friday 23 March 2007 20:23, Stefano Brivio wrote:
> Fix a duplicated leftshift in bcm43xx_radio_set_tx_iq. data_high values are
> already leftshifted. Thanks to Michael Buesch for spotting this.
>
> Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
I think you should probably write your APHY stuff against the development
tree, as only that has proper support for multiple 802.11 cores (4309).
> diff --git a/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c b/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c
> index 10a82b1..a2c52f6 100644
> --- a/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c
> +++ b/drivers/net/wireless/mac80211/bcm43xx/bcm43xx_phy.c
> @@ -3802,7 +3802,7 @@ void bcm43xx_radio_set_tx_iq(struct bcm4
>
> for (i = 0; i < 5; i++) {
> for (j = 0; j < 5; j++) {
> - if (tmp == (data_high[i] << 4 | data_low[j])) {
> + if (tmp == (data_high[i] | data_low[j])) {
> bcm43xx_phy_write(dev, 0x0069, (i - j) << 8 | 0x00C0);
> return;
> }
--
Greetings Michael.
prev parent reply other threads:[~2007-03-23 20:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 19:23 [PATCH] bcm43xx-mac80211: fix radio_set_tx_iq Stefano Brivio
2007-03-23 20:25 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703232125.59781.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.